URL Dispatcher

Merge lp://staging/~ted/url-dispatcher/bad-url-fixes into lp://staging/url-dispatcher

  1. bad-url-fixes
  2. Merge into trunk.17.04
Proposed by Ted Gould
Status: Merged
Approved by: dobey
Approved revision: 120
Merged at revision: 114
Proposed branch: lp://staging/~ted/url-dispatcher/bad-url-fixes
Merge into: lp://staging/url-dispatcher
Diff against target: 229 lines (+16/-144)
7 files modified
debian/control (+1/-1)
gui/url-dispatcher-gui.desktop.in (+1/-0)
gui/url-dispatcher-gui.svg (+1/-0)
service/bad-url/CMakeLists.txt (+1/-1)
service/bad-url/exec-tool.cpp (+12/-18)
tests/CMakeLists.txt (+0/-13)
tests/exec-tool-test.cc (+0/-111)
To merge this branch: bzr merge lp://staging/~ted/url-dispatcher/bad-url-fixes
Reviewer Review Type Date Requested Status
dobey (community) Approve
unity-api-1-bot continuous-integration Needs Fixing
Review via email: mp+320100@code.staging.launchpad.net

Commit message

Update bad-url exec tool to UAL C++ interface

Description of the change

This doesn't fix the bad url support but cleans up some cruft and removes a test that we don't want to port to systemd.

To post a comment you must log in.
Revision history for this message
unity-api-1-bot (unity-api-1-bot) wrote :

FAILED: Continuous integration, rev:117
https://jenkins.canonical.com/unity-api-1/job/lp-url-dispatcher-ci/54/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build/1800/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/1807
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1583/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1583/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1583/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1583/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1583/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1583/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-url-dispatcher-ci/54/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
dobey (dobey) :
review: Needs Information
lp://staging/~ted/url-dispatcher/bad-url-fixes updated
118. By Ted Gould

Make return values clearer

Revision history for this message
Ted Gould (ted) wrote :

We don't need dbus anymore. The URLs are taken care of by UAL. But the return codes should be explicit. Fixed that in r118.

Revision history for this message
unity-api-1-bot (unity-api-1-bot) wrote :

FAILED: Continuous integration, rev:118
https://jenkins.canonical.com/unity-api-1/job/lp-url-dispatcher-ci/55/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build/1820/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/1827
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1603/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1603/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1603/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1603/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1603/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1603/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-url-dispatcher-ci/55/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
dobey (dobey) :
lp://staging/~ted/url-dispatcher/bad-url-fixes updated
119. By Ted Gould

Turn UAL up to 11

Revision history for this message
unity-api-1-bot (unity-api-1-bot) wrote :

FAILED: Continuous integration, rev:119
https://jenkins.canonical.com/unity-api-1/job/lp-url-dispatcher-ci/57/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build/1823/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/1830
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1606/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1606/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1606/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1606/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1606/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1606/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-url-dispatcher-ci/57/rebuild

review: Needs Fixing (continuous-integration)
lp://staging/~ted/url-dispatcher/bad-url-fixes updated
120. By Ted Gould

Remove tabs for dobey

Revision history for this message
unity-api-1-bot (unity-api-1-bot) wrote :

FAILED: Continuous integration, rev:120
https://jenkins.canonical.com/unity-api-1/job/lp-url-dispatcher-ci/58/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build/1824/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/1831
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1607/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1607/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1607/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1607/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1607/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1607/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-url-dispatcher-ci/58/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
dobey (dobey) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches