ubuntu-system-settings

Merge lp://staging/~ted/ubuntu-system-settings/about-headers into lp://staging/ubuntu-system-settings

  1. about-headers
  2. Merge into trunk
Proposed by Ted Gould
Status: Rejected
Rejected by: Sebastien Bacher
Proposed branch: lp://staging/~ted/ubuntu-system-settings/about-headers
Merge into: lp://staging/ubuntu-system-settings
Diff against target: 43 lines (+9/-2)
2 files modified
plugins/about/DevMode.qml (+1/-0)
plugins/about/PageComponent.qml (+8/-2)
To merge this branch: bzr merge lp://staging/~ted/ubuntu-system-settings/about-headers
Reviewer Review Type Date Requested Status
Sebastien Bacher (community) Disapprove
PS Jenkins bot continuous-integration Needs Fixing
Review via email: mp+238649@code.staging.launchpad.net

Commit message

Use the header item for the header labels

Description of the change

Was just looking at the sounds stuff, then checked a version and noticed a couple of quick fixes that could be done here. Not biggies, just making it a little easier to read and closer to the spec.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1136
http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-ci/1653/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/6010
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/4126
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-utopic-i386-ci/845
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/5647
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/7262
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/7262/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/14789
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/3487
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/4463
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/4463/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-ci/1653/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks, but those are not headers, see bug #1190234 and mpt's comment

"the introductory labels are not headers. They are just labels, and should use the same font, color, and alignment as labels inside list items do."

review: Disapprove

Unmerged revisions

1136. By Ted Gould

No divider on storage

1135. By Ted Gould

Hide the divider under the update button

1134. By Ted Gould

Avoid a duplicate line

1133. By Ted Gould

Use headers with dividers to make easier to scan

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches