Ubuntu Application Launcher

Merge lp://staging/~ted/ubuntu-app-launch/xmir-by-default into lp://staging/ubuntu-app-launch

  1. xmir-by-default
  2. Merge into trunk.17.04
Proposed by Ted Gould
Status: Merged
Approved by: dobey
Approved revision: 299
Merged at revision: 295
Proposed branch: lp://staging/~ted/ubuntu-app-launch/xmir-by-default
Merge into: lp://staging/ubuntu-app-launch
Diff against target: 53 lines (+11/-4)
3 files modified
debian/control (+1/-0)
libubuntu-app-launch/application-impl-legacy.cpp (+8/-2)
tests/exec-util-test.cc (+2/-2)
To merge this branch: bzr merge lp://staging/~ted/ubuntu-app-launch/xmir-by-default
Reviewer Review Type Date Requested Status
Daniel d'Andrada Needs Fixing
dobey (community) Approve
unity-api-1-bot continuous-integration Approve
kevin gunn Pending
Review via email: mp+318834@code.staging.launchpad.net

Commit message

XMir by default for Legacy apps

To post a comment you must log in.
Revision history for this message
Ted Gould (ted) wrote :

https://bileto.ubuntu.com/#/ticket/2531

Revision history for this message
unity-api-1-bot (unity-api-1-bot) wrote :

FAILED: Continuous integration, rev:295
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/241/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build/1739/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/1746
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1521
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1521/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1521/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1521
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1521/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1521/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1521
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1521/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1521/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/241/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
unity-api-1-bot (unity-api-1-bot) wrote :

FAILED: Continuous integration, rev:295
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/243/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build/1745/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/1752
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1527
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1527/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1527/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1527
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1527/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1527/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1527
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1527/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1527/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/243/rebuild

review: Needs Fixing (continuous-integration)
lp://staging/~ted/ubuntu-app-launch/xmir-by-default updated
296. By Ted Gould

Wrong bitwise operator vs. logic

Revision history for this message
unity-api-1-bot (unity-api-1-bot) wrote :

FAILED: Continuous integration, rev:296
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/244/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build/1746/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/1753
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1529/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1529/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1529/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1529/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1529/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1529/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/244/rebuild

review: Needs Fixing (continuous-integration)
lp://staging/~ted/ubuntu-app-launch/xmir-by-default updated
297. By Ted Gould

Fix tests to map changes to enabling XMir

Revision history for this message
unity-api-1-bot (unity-api-1-bot) wrote :

FAILED: Continuous integration, rev:297
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/245/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build/1751/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/1758
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1533
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1533/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1533
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1533/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1533
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1533/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1533/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1533
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1533/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1533/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/245/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
unity-api-1-bot (unity-api-1-bot) wrote :

FAILED: Continuous integration, rev:297
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/246/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build/1752/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/1759
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1535
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1535/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1535/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1535
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1535/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1535
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1535/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1535
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1535/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1535
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1535/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/246/rebuild

review: Needs Fixing (continuous-integration)
lp://staging/~ted/ubuntu-app-launch/xmir-by-default updated
298. By Ted Gould

Only default to XMir if there isn't a touch key set

Revision history for this message
dinamic (dinamic6661) wrote :

but now it launches apps like kate or qupzilla (qt5) that run native on mir with Xmir. i guess i can workarround this just by adding x-ubuntu-touch=true? to the .desktop file

Revision history for this message
Ted Gould (ted) wrote :

On Tue, 2017-03-07 at 16:30 +0000, dinamic wrote:
> but now it launches apps like kate or qupzilla (qt5) that run native
> on mir with Xmir. i guess i can workarround this just by adding x-
> ubuntu-touch=true? to the .desktop file
 There are two keys, X-Ubuntu-XMir-Enable and X-Ubuntu-Touch. If you
just want to disable XMir I'd use the first key. If you want to sign on
to full Unity8 lifecycle and such, use the second. But yes, it will
have to be opt-in for now.

Revision history for this message
unity-api-1-bot (unity-api-1-bot) wrote :

FAILED: Continuous integration, rev:298
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/248/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build/1755/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/1762
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1538/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1538/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1538
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1538/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1538
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1538/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1538
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1538/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1538
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1538/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/248/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
dinamic (dinamic6661) wrote :

i see :D thanks! o/

lp://staging/~ted/ubuntu-app-launch/xmir-by-default updated
299. By Ted Gould

Adding in libertine-tools dependency needed for XMir helpers

Revision history for this message
unity-api-1-bot (unity-api-1-bot) wrote :

PASSED: Continuous integration, rev:299
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/249/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build/1756
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/1763
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1539
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1539/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1539
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1539/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1539
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1539/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1539
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1539/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1539
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1539/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1539
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1539/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/249/rebuild

review: Approve (continuous-integration)
Revision history for this message
dobey (dobey) wrote :

Would prefer a Recommends for libertine-tools, but meh.

review: Approve
Revision history for this message
Daniel d'Andrada (dandrader) wrote :

Installed that in my laptop and now all qt apps are being launched under xmir!

review: Needs Fixing
Revision history for this message
dobey (dobey) wrote :

> Installed that in my laptop and now all qt apps are being launched under xmir!

This is correct if they don't specify they should use mir by default. We can't intuit what toolkit an app uses. Majority of toolkits do not support Mir.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches