Merge into trunk.16.10 : snappy-backend-no-snap : Code : Ubuntu Application Launcher

Status:	Merged
Approved by:	Ted Gould on 2016-09-14
Approved revision:	371
Merged at revision:	252
Proposed branch:	lp://staging/~ted/ubuntu-app-launch/snappy-backend-no-snap
Merge into:	lp://staging/ubuntu-app-launch/16.10
Prerequisite:	lp://staging/~ted/ubuntu-app-launch/snappy-backend-no-find-discover
Diff against target:	1419 lines (+698/-265) 14 files modified docs/index.rst (+11/-1) libubuntu-app-launch/app-info.c (+6/-128) libubuntu-app-launch/app-info.h (+0/-35) libubuntu-app-launch/appid.h (+61/-0) libubuntu-app-launch/application-impl-click.cpp (+109/-0) libubuntu-app-launch/application-impl-click.h (+27/-0) libubuntu-app-launch/application-impl-legacy.cpp (+102/-6) libubuntu-app-launch/application-impl-legacy.h (+26/-0) libubuntu-app-launch/application-impl-libertine.cpp (+97/-0) libubuntu-app-launch/application-impl-libertine.h (+30/-0) libubuntu-app-launch/application.cpp (+173/-51) libubuntu-app-launch/registry.cpp (+1/-1) libubuntu-app-launch/ubuntu-app-launch.cpp (+18/-11) tests/libual-cpp-test.cc (+37/-32)
To merge this branch:	bzr merge lp://staging/~ted/ubuntu-app-launch/snappy-backend-no-snap
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Charles Kerr (community)		2016-08-04	Approve on 2016-09-06
unity-api-1-bot	continuous-integration	2016-08-04	Approve on 2016-09-06
Review via email: mp+302025@code.staging.launchpad.net

Revision history for this message

unity-api-1-bot (unity-api-1-bot) wrote on 2016-08-04: Posted in a previous version of this proposal

#

FAILED: Continuous integration, rev:352
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~ted/ubuntu-app-launch/snappy-backend-no-snap/+merge/301966/+edit-commit-message

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/18/rebuild

FAILED: Continuous integration, rev:352
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~ted/ubuntu-app-launch/snappy-backend-no-snap/+merge/301966/+edit-commit-message

https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/18/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build/277/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/283
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-1-sourcepkg/release=vivid+overlay/217
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-1-sourcepkg/release=xenial+overlay/217
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-1-sourcepkg/release=yakkety/217
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=vivid+overlay/146/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/146/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=yakkety/146/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=vivid+overlay/146/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/146/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=yakkety/146/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=vivid+overlay/146/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/146/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=yakkety/146/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/18/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

unity-api-1-bot (unity-api-1-bot) wrote on 2016-08-05:

#

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/30/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~ted/ubuntu-app-launch/snappy-backend-no-snap updated on 2016-08-12

358. By Ted Gould on 2016-08-12: Pull through OOM updates

Revision history for this message

unity-api-1-bot (unity-api-1-bot) wrote on 2016-08-13:

#

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/51/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~ted/ubuntu-app-launch/snappy-backend-no-snap updated on 2016-08-23

359. By Ted Gould on 2016-08-18: Fix legacy instance pull through
360. By Ted Gould on 2016-08-23: Updating to trunk

Revision history for this message

unity-api-1-bot (unity-api-1-bot) wrote on 2016-08-23:

#

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/62/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Charles Kerr (charlesk) wrote on 2016-08-24:

#

By some yardstick this was an easier review -- the code diff is smaller -- but I had a lot of questions about the type-specific methods.

Questions and comments inline

Revision history for this message

Ted Gould (ted) wrote on 2016-08-24:

#

Download full text (5.3 KiB)

On Wed, 2016-08-24 at 18:53 +0000, Charles Kerr wrote:
> By some yardstick this was an easier review -- the code diff is
> smaller -- but I had a lot of questions about the type-specific
> methods.

I think a lot of your questions came from not knowing the different
AppID schemes, which really means we didn't do a good job of
documenting that. So I tried to do that with narrative text on each of
the implementations: r363

> > + if (apps.size() == 0)
> apps is a std::list<> so size() has to walk the list.
>
> Since size is used twice in this function (here and in ONLY_LISTED
> below) better to store it in a temporary.
>
> In general, better to say "if (!foo.empty())" than "if (foo.size() ==
> 0)"

List size is constant since C++11: http://en.cppreference.com/w/cpp/con
tainer/list/size

But yes, empty would look better. r364

> > +    switch (card)
> > +    {
> > +        case AppID::ApplicationWildcard::FIRST_LISTED:
> > +            return *apps.begin();
> > +        case AppID::ApplicationWildcard::LAST_LISTED:
> out-of-scope for this review, but as an aside, what's the use case
> for LAST_LISTED?

Added for completeness, seemed odd to have first and only but not last.
I think almost everyone uses first.

> > +    catch (std::runtime_error& e)
> > +    {
> > +        return false;
> does e.what need to be logged here? Looks like the answer is 'no' but
> wanted to be sure

No, it gets checked a fair amount and would be too chatty.

> +bool Legacy::verifyPackage(const AppID::Package& package, const
> > std::shared_ptr<Registry>& registry)
> > +{
> > + return package.value().empty();
> (needinfo) Wait, whaaaat? Why would a function named verifyPackage()
> return true iff no package?

For Legacy apps the package field is empty.

> > + std::string desktop = std::string(appname) + ".desktop";
> redundant type information, suggest auto on lhs
> > >
> > + std::function<bool(const gchar* dir)> evaldir =
> > [&desktop](const gchar* dir) {
> redundant type information, suggest auto on lhs

r365

> > +AppID::Version Legacy::findVersion(const AppID::Package& package,
> > +                                   const AppID::AppName& appname,
> > +                                   const
> > std::shared_ptr<Registry>& registry)
> > +{
> > +    return AppID::Version::from_raw({});
> (needinfo) Why does findAppname() throw but findVersion() returns
> empty?

So my thought there was that if you're looking for the version, the
answer is always "", but we can't ever find an application, so that's
an error.

> > +/** Checks the AppID by making sure the version is "0.0" and then
> > + calling verifyAppname() to check the rest.
> (needinfo) Same "whaaaat" as above, I think I'm missing some context
> here. I don't understand what this is for, nor why a 0.0 test is
> useful

All Libertine applications have a version string of "0.0".

Using it as a test to reject things quickly. Since basically our
algorithm is "try all implementations" we end up with wanting to reject
as much as possible.

> > +    catch (std::runtime_error& e)
> > +    {
> > +        return false;
> is this normal, or should e.what() be logged?

Normal.

> > + auto container =...

On Wed, 2016-08-24 at 18:53 +0000, Charles Kerr wrote:
> By some yardstick this was an easier review -- the code diff is
> smaller -- but I had a lot of questions about the type-specific
> methods.

I think a lot of your questions came from not knowing the different
AppID schemes, which really means we didn't do a good job of
documenting that. So I tried to do that with narrative text on each of
the implementations: r363

> > +    if (apps.size() == 0)
> apps is a std::list<> so size() has to walk the list.
> 
> Since size is used twice in this function (here and in ONLY_LISTED
> below) better to store it in a temporary.
> 
> In general, better to say "if (!foo.empty())" than "if (foo.size() ==
> 0)"

List size is constant since C++11: http://en.cppreference.com/w/cpp/con
tainer/list/size

But yes, empty would look better. r364

> > +    switch (card)
> > +    {
> > +        case AppID::ApplicationWildcard::FIRST_LISTED:
> > +            return *apps.begin();
> > +        case AppID::ApplicationWildcard::LAST_LISTED:
> out-of-scope for this review, but as an aside, what's the use case
> for LAST_LISTED?

Added for completeness, seemed odd to have first and only but not last.
I think almost everyone uses first.

> > +    catch (std::runtime_error& e)
> > +    {
> > +        return false;
> does e.what need to be logged here? Looks like the answer is 'no' but
> wanted to be sure

No, it gets checked a fair amount and would be too chatty.

> +bool Legacy::verifyPackage(const AppID::Package& package, const
> > std::shared_ptr<Registry>& registry)
> > +{
> > +    return package.value().empty();
> (needinfo) Wait, whaaaat? Why would a function named verifyPackage()
> return true iff no package?

For Legacy apps the package field is empty.

> > +    std::string desktop = std::string(appname) + ".desktop";
> redundant type information, suggest auto on lhs
> > > 
> > +    std::function<bool(const gchar* dir)> evaldir =
> > [&desktop](const gchar* dir) {
> redundant type information, suggest auto on lhs

r365

> > +AppID::Version Legacy::findVersion(const AppID::Package& package,
> > +                                   const AppID::AppName& appname,
> > +                                   const
> > std::shared_ptr<Registry>& registry)
> > +{
> > +    return AppID::Version::from_raw({});
> (needinfo) Why does findAppname() throw but findVersion() returns
> empty?

So my thought there was that if you're looking for the version, the
answer is always "", but we can't ever find an application, so that's
an error.

> > +/** Checks the AppID by making sure the version is "0.0" and then
> > +    calling verifyAppname() to check the rest.
> (needinfo) Same "whaaaat" as above, I think I'm missing some context
> here. I don't understand what this is for, nor why a 0.0 test is
> useful

All Libertine applications have a version string of "0.0".

Using it as a test to reject things quickly. Since basically our
algorithm is "try all implementations" we end up with wanting to reject
as much as possible.

> > +    catch (std::runtime_error& e)
> > +    {
> > +        return false;
> is this normal, or should e.what() be logged?

Normal.

> > +        auto container = containers.get()[i];
> > +        if (std::string(container) == package.value())
> bool operator==( const CharT* lhs, const
> basic_string<CharT,Traits,Alloc>& rhs ) exists, so there's no need
> for the std::string temporary:
> > if (container == package.value())

r366

> +/** Basically we're making our own VTable of static functions.
> > Static
> > +    functions don't go in the normal VTables, so we can't use our
> > class
> > +    inheritance here to help. So we're just packing these puppies
> > into
> > +    a data structure and itterating over it. */
> 1. s/itterating/iterating/

r367

> 2. This is a really strange mechanism, I wish there was a better
> approach than looping through DiscoverTools instances

Yeah, but hopefully most users won't get AppIDs through discovery as
much as keep Application objects around and use those. Or just be
checking their versions which is relatively cheap. Most of the more
advanced functions here are as much syntactic sugar to make everything
feel available, even if it is costly.

> > +AppID AppID::discover(const std::shared_ptr<Registry>& registry,
> > +                      const std::string& package,
> > +                      const std::string& appname,
> > +                      const std::string& version)
> > +{
> > +    auto pkg = AppID::Package::from_raw(package);
> > +
> > +    for (auto tools : discoverTools)
> auto&, here and below in the other "for (auto tools : discoverTools)"
> uses

There is no way the compiler would need this ;-)
r368

> > +                    app = AppID::AppName::from_raw(appname);
> > +                    if (!tools.verifyAppname(pkg, app, registry))
> > +                    {
> > +                        throw std::runtime_error("App name passed
> > in is not valid for this package type");
> This isn't logged or anything down in the catch block, why not avoid
> the try-catch overhead and just call "continue" here?

So I went this route so that there was one control scheme going on in
the function. Everything is an exception whether it is from one of the
functions themselves or this code. I figured the overhead would be
minimal as the compiler is likely to optimize to a jump anyway. I put
the string in as a comment.

lp://staging/~ted/ubuntu-app-launch/snappy-backend-no-snap updated on 2016-08-24

361. By Ted Gould on 2016-08-24: Bring in updates to no-find-discover branch
362. By Ted Gould on 2016-08-24: Fix abicheck
363. By Ted Gould on 2016-08-24: Write text explaining the app id schemes for the various backends
364. By Ted Gould on 2016-08-24: Use empty instead of checking the size
365. By Ted Gould on 2016-08-24: Going full auto
366. By Ted Gould on 2016-08-24: Removing a string cast
367. By Ted Gould on 2016-08-24: Spelling fix
368. By Ted Gould on 2016-08-24: Make sure we don't copy the tools structures

Revision history for this message

unity-api-1-bot (unity-api-1-bot) wrote on 2016-08-24:

#

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/66/rebuild

FAILED: Continuous integration, rev:368
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/66/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build/475/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/481
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-1-sourcepkg/release=vivid+overlay/386
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-1-sourcepkg/release=xenial+overlay/386
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-1-sourcepkg/release=yakkety/386
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=vivid+overlay/316/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/316
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/316/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=yakkety/316
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=yakkety/316/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=vivid+overlay/316/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/316
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/316/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=yakkety/316
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=yakkety/316/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=vivid+overlay/316/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/316
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/316/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=yakkety/316
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=yakkety/316/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/66/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Charles Kerr (charlesk) wrote on 2016-08-25:

#

Thanks for the changes, especially the extra explanations. :)

review: Approve

lp://staging/~ted/ubuntu-app-launch/snappy-backend-no-snap updated on 2016-08-26

369. By Ted Gould on 2016-08-26: Grab changes and Jenkins fixes

Revision history for this message

unity-api-1-bot (unity-api-1-bot) wrote on 2016-08-26:

#

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/79/rebuild

PASSED: Continuous integration, rev:369
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/79/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build/506
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/512
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-1-sourcepkg/release=vivid+overlay/417
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-1-sourcepkg/release=xenial+overlay/417
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-1-sourcepkg/release=yakkety/417
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=vivid+overlay/347
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=vivid+overlay/347/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/347
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/347/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=yakkety/347
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=yakkety/347/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=vivid+overlay/347
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=vivid+overlay/347/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/347
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/347/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=yakkety/347
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=yakkety/347/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=vivid+overlay/347
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=vivid+overlay/347/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/347
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/347/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=yakkety/347
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=yakkety/347/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/79/rebuild

review: Approve (continuous-integration)

lp://staging/~ted/ubuntu-app-launch/snappy-backend-no-snap updated on 2016-08-26

370. By Ted Gould on 2016-08-26: Getting some list bus love

Revision history for this message

unity-api-1-bot (unity-api-1-bot) wrote on 2016-08-26:

#

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/83/rebuild

PASSED: Continuous integration, rev:370
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/83/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build/512
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/518
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-1-sourcepkg/release=vivid+overlay/423
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-1-sourcepkg/release=xenial+overlay/423
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-1-sourcepkg/release=yakkety/423
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=vivid+overlay/353
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=vivid+overlay/353/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/353
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/353/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=yakkety/353
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=yakkety/353/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=vivid+overlay/353
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=vivid+overlay/353/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/353
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/353/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=yakkety/353
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=yakkety/353/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=vivid+overlay/353
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=vivid+overlay/353/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/353
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/353/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=yakkety/353
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=yakkety/353/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/83/rebuild

review: Approve (continuous-integration)

lp://staging/~ted/ubuntu-app-launch/snappy-backend-no-snap updated on 2016-09-06

371. By Ted Gould on 2016-09-06: Merging trunk

Revision history for this message

unity-api-1-bot (unity-api-1-bot) wrote on 2016-09-06:

#

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/93/rebuild

PASSED: Continuous integration, rev:371
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/93/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build/563
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/569
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=vivid+overlay/397
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=vivid+overlay/397/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/397
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/397/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=yakkety/397
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=yakkety/397/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=vivid+overlay/397
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=vivid+overlay/397/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/397
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/397/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=yakkety/397
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=yakkety/397/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=vivid+overlay/397
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=vivid+overlay/397/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/397
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/397/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=yakkety/397
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=yakkety/397/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/93/rebuild

review: Approve (continuous-integration)

Revision history for this message

Charles Kerr (charlesk) wrote on 2016-09-06:

#

Reapprove to pick up r370

review: Approve

Ubuntu Application Launcher

Merge lp://staging/~ted/ubuntu-app-launch/snappy-backend-no-snap into lp://staging/ubuntu-app-launch/16.10

Commit message

Description of the change

Preview Diff

Subscribers