Merge lp://staging/~ted/ubuntu-app-launch/oom-adjust-file into lp://staging/ubuntu-app-launch/14.10
Proposed by
Ted Gould
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Charles Kerr | ||||
| Approved revision: | 179 | ||||
| Merged at revision: | 173 | ||||
| Proposed branch: | lp://staging/~ted/ubuntu-app-launch/oom-adjust-file | ||||
| Merge into: | lp://staging/ubuntu-app-launch/14.10 | ||||
| Diff against target: |
193 lines (+72/-19) 4 files modified
libubuntu-app-launch/ubuntu-app-launch.c (+40/-17) tests/libual-test.cc (+26/-2) upstart-jobs/application-click.conf.in (+3/-0) upstart-jobs/application-legacy.conf.in (+3/-0) |
||||
| To merge this branch: | bzr merge lp://staging/~ted/ubuntu-app-launch/oom-adjust-file | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Charles Kerr (community) | Approve | ||
| PS Jenkins bot (community) | continuous-integration | Approve | |
|
Review via email:
|
|||
Commit message
Set OOM adjustment without using temporary files.
Description of the change
Fixes the OOM adjustment code which was using set_file_contents, which should work in theory, but internally it works by creating a temp file and renaming it. Which doesn't really work in /proc. So now going with the good ol' fwrite.
Also, figured out how to test this code. So now we're checking values.
To post a comment you must log in.
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Approve
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
PASSED: Continuous integration, rev:179
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://