Ubuntu Application Launcher

Merge lp://staging/~ted/ubuntu-app-launch/jobs-systemd into lp://staging/ubuntu-app-launch

  1. jobs-systemd
  2. Merge into trunk.17.04
Proposed by Ted Gould
Status: Merged
Approved by: Ted Gould
Approved revision: 403
Merged at revision: 281
Proposed branch: lp://staging/~ted/ubuntu-app-launch/jobs-systemd
Merge into: lp://staging/ubuntu-app-launch
Prerequisite: lp://staging/~ted/ubuntu-app-launch/jobs-tests
Diff against target: 3215 lines (+2555/-102)
31 files modified
debian/rules (+4/-1)
libubuntu-app-launch/CMakeLists.txt (+4/-0)
libubuntu-app-launch/application-impl-base.cpp (+26/-0)
libubuntu-app-launch/application-impl-base.h (+3/-0)
libubuntu-app-launch/application-impl-click.cpp (+6/-0)
libubuntu-app-launch/application-impl-legacy.cpp (+4/-17)
libubuntu-app-launch/application-impl-legacy.h (+0/-1)
libubuntu-app-launch/application-impl-libertine.cpp (+11/-8)
libubuntu-app-launch/application-impl-snap.cpp (+8/-4)
libubuntu-app-launch/application-info-desktop.cpp (+1/-0)
libubuntu-app-launch/application-info-desktop.h (+8/-0)
libubuntu-app-launch/helper.h (+10/-10)
libubuntu-app-launch/jobs-base.cpp (+47/-2)
libubuntu-app-launch/jobs-base.h (+7/-0)
libubuntu-app-launch/jobs-systemd.cpp (+1329/-0)
libubuntu-app-launch/jobs-systemd.h (+136/-0)
libubuntu-app-launch/jobs-upstart.cpp (+0/-25)
libubuntu-app-launch/registry-impl.cpp (+1/-1)
libubuntu-app-launch/snapd-info.cpp (+1/-1)
tests/CMakeLists.txt (+11/-0)
tests/eventually-fixture.h (+9/-0)
tests/exec-util-test.cc (+10/-0)
tests/failure-test.cc (+2/-0)
tests/jobs-base-test.cpp (+1/-22)
tests/jobs-systemd.cpp (+362/-0)
tests/libual-cpp-test.cc (+11/-10)
tests/libual-test.cc (+1/-0)
tests/registry-mock.h (+57/-0)
tests/spew-master.h (+2/-0)
tests/systemd-mock.h (+481/-0)
xmir-helper.c (+2/-0)
To merge this branch: bzr merge lp://staging/~ted/ubuntu-app-launch/jobs-systemd
Reviewer Review Type Date Requested Status
unity-api-1-bot continuous-integration Needs Fixing
Charles Kerr (community) Approve
Review via email: mp+310590@code.staging.launchpad.net

This proposal supersedes a proposal from 2016-10-26.

Commit message

SystemD backend added

To post a comment you must log in.
Revision history for this message
unity-api-1-bot (unity-api-1-bot) wrote :

FAILED: Continuous integration, rev:372
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/178/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build/1515/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/1522
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1300
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1300/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1300/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1300
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1300/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1300
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1300/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1300/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1300
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1300/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/178/rebuild

review: Needs Fixing (continuous-integration)
lp://staging/~ted/ubuntu-app-launch/jobs-systemd updated
373. By Ted Gould

Update to trunk

Revision history for this message
unity-api-1-bot (unity-api-1-bot) wrote :

FAILED: Continuous integration, rev:373
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/183/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build/1526/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/1533
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1311
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1311/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1311
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1311/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1311/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1311
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1311/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1311
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1311/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1311
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1311/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/183/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Charles Kerr (charlesk) wrote :

Comments inline.

As usual, mostly questions & minor. A few NF but nothing requiring major surgery.

review: Needs Fixing
lp://staging/~ted/ubuntu-app-launch/jobs-systemd updated
374. By Ted Gould

Make getInstance a const method

375. By Ted Gould

Const getAllJobs()

376. By Ted Gould

Comment formatting, whatevs

377. By Ted Gould

Header reshuffle

378. By Ted Gould

Charles hates returns on void functions

379. By Ted Gould

We don't need no stinkin' std::string object

380. By Ted Gould

Remove some printouts when we cancel

381. By Ted Gould

Protect more against null GVariant pointers

382. By Ted Gould

Make the signal handlers safer

383. By Ted Gould

Make parseUnit and unitName const

384. By Ted Gould

Name lamba better

385. By Ted Gould

Use std::vector<> constructor instead of a loop

386. By Ted Gould

Be louder about not having an exec line

387. By Ted Gould

Getting rid of a TODO

388. By Ted Gould

Move declarations

389. By Ted Gould

Avoid calling getenv() twice

390. By Charles Kerr

Cleaner name finding

391. By Ted Gould

Make lists into real lists

392. By Ted Gould

Make sure we don't copy commands

393. By Ted Gould

Making sure we calculate the string once

394. By Ted Gould

Don't get all the jobs until we're sure we have a registry

395. By Ted Gould

Remove try/catch that isn't needed

396. By Ted Gould

Switching to static_cast<>

397. By Ted Gould

Fixing up the failure signals

398. By Charles Kerr

Clearer sorting

399. By Ted Gould

Overrides

Revision history for this message
Ted Gould (ted) :
Revision history for this message
unity-api-1-bot (unity-api-1-bot) wrote :

FAILED: Continuous integration, rev:399
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/184/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build/1528/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/1535
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1313
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1313/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1313
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1313/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1313
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1313/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1313
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1313/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1313/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1313
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1313/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/184/rebuild

review: Needs Fixing (continuous-integration)
lp://staging/~ted/ubuntu-app-launch/jobs-systemd updated
400. By Ted Gould

Test the exec line and ensure it doesn't fail

Revision history for this message
unity-api-1-bot (unity-api-1-bot) wrote :

FAILED: Continuous integration, rev:400
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/188/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build/1532/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/1539
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1317
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1317/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1317
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1317/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1317
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1317/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1317/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1317/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1317
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1317/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/188/rebuild

review: Needs Fixing (continuous-integration)
lp://staging/~ted/ubuntu-app-launch/jobs-systemd updated
401. By Ted Gould

Don't crash free memory, works but is odd

402. By Ted Gould

Use the g_array functions to avoid some casts

Revision history for this message
unity-api-1-bot (unity-api-1-bot) wrote :

FAILED: Continuous integration, rev:402
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/189/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build/1533/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/1540
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1318
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1318/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1318
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1318/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1318
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1318/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1318/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1318
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1318/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1318
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1318/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/189/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Charles Kerr (charlesk) wrote :

I'm happy with these changes, feel free to top-approve once the Jenkins issue is resolved (or if it's a false issue)

review: Approve
lp://staging/~ted/ubuntu-app-launch/jobs-systemd updated
403. By Ted Gould

Making sure everything is on the right bus

Revision history for this message
unity-api-1-bot (unity-api-1-bot) wrote :

FAILED: Continuous integration, rev:403
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/197/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build/1584/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/1591
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1369/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1369/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1369/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1369/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1369/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1369/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/197/rebuild

review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches