Ubuntu Application Launcher

Merge lp://staging/~ted/ubuntu-app-launch/jobs-helpers into lp://staging/ubuntu-app-launch

  1. jobs-helpers
  2. Merge into trunk.17.04
Proposed by Ted Gould
Status: Merged
Approved by: Ted Gould
Approved revision: 346
Merged at revision: 302
Proposed branch: lp://staging/~ted/ubuntu-app-launch/jobs-helpers
Merge into: lp://staging/ubuntu-app-launch
Prerequisite: lp://staging/~ted/ubuntu-app-launch/app-store
Diff against target: 3242 lines (+1100/-1406)
22 files modified
CMakeLists.txt (+1/-41)
debian/changelog (+6/-0)
docs/index.rst (+12/-3)
libubuntu-app-launch/CMakeLists.txt (+4/-2)
libubuntu-app-launch/helper-impl-click.cpp (+0/-176)
libubuntu-app-launch/helper-impl-click.h (+0/-62)
libubuntu-app-launch/helper-impl.h (+80/-0)
libubuntu-app-launch/helper.cpp (+0/-36)
libubuntu-app-launch/helper.h (+6/-0)
libubuntu-app-launch/jobs-base.cpp (+257/-4)
libubuntu-app-launch/jobs-base.h (+48/-8)
libubuntu-app-launch/jobs-systemd.cpp (+24/-52)
libubuntu-app-launch/jobs-systemd.h (+11/-12)
libubuntu-app-launch/jobs-upstart.cpp (+49/-69)
libubuntu-app-launch/jobs-upstart.h (+19/-20)
libubuntu-app-launch/registry.cpp (+28/-8)
libubuntu-app-launch/registry.h (+31/-0)
libubuntu-app-launch/ubuntu-app-launch.cpp (+219/-908)
tests/snappy-xmir-test.sh.in (+3/-3)
tests/xmir-helper-test.in (+2/-2)
utils/CMakeLists.txt (+56/-0)
utils/systemd-helper-helper.c (+244/-0)
To merge this branch: bzr merge lp://staging/~ted/ubuntu-app-launch/jobs-helpers
Reviewer Review Type Date Requested Status
unity-api-1-bot continuous-integration Needs Fixing
Charles Kerr (community) Approve
Review via email: mp+318310@code.staging.launchpad.net

This proposal supersedes a proposal from 2017-02-22.

Commit message

Moving untrusted helpers over to the jobs objects.

Description of the change

This moves the helper code over to using jobs objects so that they're not using Upstart directly. There were a few changes required in the jobs objects as a result to clean them up so they're not entirely application focused.

The tests do not work on this branch. As we're breaking all the upstart and click stuff all the tests are fixed at the rm-rf-click branch and these should land together.

To post a comment you must log in.
Revision history for this message
unity-api-1-bot (unity-api-1-bot) wrote :

FAILED: Continuous integration, rev:324
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/257/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build/1782/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/1789
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1565/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1565/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1565/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1565/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1565/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1565/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/257/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
unity-api-1-bot (unity-api-1-bot) wrote :

FAILED: Continuous integration, rev:326
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/260/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build/1791/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/1798
    ABORTED: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1574/console
    ABORTED: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1574/console
    ABORTED: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1574/console
    ABORTED: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1574/console
    ABORTED: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1574/console
    ABORTED: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1574/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/260/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
unity-api-1-bot (unity-api-1-bot) wrote :

FAILED: Continuous integration, rev:327
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/262/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build/1821/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/1828
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1604/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1604/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1604/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1604/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1604/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1604/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/262/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
unity-api-1-bot (unity-api-1-bot) wrote :

FAILED: Continuous integration, rev:328
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/263/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build/1825/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/1832
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1608/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1608/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1608/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1608/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1608/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1608/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/263/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
unity-api-1-bot (unity-api-1-bot) wrote :

FAILED: Continuous integration, rev:329
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/264/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build/1826/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/1833
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1609/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1609/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1609/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1609/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1609/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1609/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/264/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
unity-api-1-bot (unity-api-1-bot) wrote :

FAILED: Continuous integration, rev:336
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/265/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build/1827/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/1834
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1610/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1610/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1610/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1610/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1610/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1610/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/265/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
unity-api-1-bot (unity-api-1-bot) wrote :

FAILED: Continuous integration, rev:340
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/269/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build/1831/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/1838
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1614/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1614/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1614/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1614/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1614/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1614/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/269/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
unity-api-1-bot (unity-api-1-bot) wrote :

FAILED: Continuous integration, rev:341
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/274/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build/1843/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/1850
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1626/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1626/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1626/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1626/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1626/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1626/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/274/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
unity-api-1-bot (unity-api-1-bot) wrote :

FAILED: Continuous integration, rev:342
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/276/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build/1846/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/1853
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1629/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1629/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1629/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1629/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1629/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1629/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/276/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Charles Kerr (charlesk) wrote :

LGTM.

I /do/ like the mechanism you're using to lazy-wire up the signal backends when client code asks for the core::Signal. In general this jobs management is an improvement over the previous code.

review: Approve
Revision history for this message
unity-api-1-bot (unity-api-1-bot) wrote :

FAILED: Continuous integration, rev:345
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/277/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build/1847/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/1854
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1630/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1630/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1630/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1630/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1630/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1630/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/277/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Ted Gould (ted) wrote :

On Mon, 2017-03-20 at 23:14 +0000, Charles Kerr wrote:
> (Minor) Under what conditions would the job not be in allJobs? Does
> this warrant logging an error? (here and below)
 So, I see why you're confused. It shouldn't be "allJobs" it should be
"allApplicationJobs". The helpers have a job name based on the type. So
since this signal is for application start/stopped it filters out the
helpers. I'm thinking we can clean this up in the future, but it's just
a direct port from the Upstart application jobs that we had. We can
probably simplify it a bit now that we're dropping the Upstart backend.
Fixed r346

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches