Merge into trunk.16.10 : eventually-tests : Code : Ubuntu Application Launcher

Status:	Merged
Approved by:	Charles Kerr on 2016-08-17
Approved revision:	265
Merged at revision:	241
Proposed branch:	lp://staging/~ted/ubuntu-app-launch/eventually-tests
Merge into:	lp://staging/ubuntu-app-launch/16.10
Diff against target:	1327 lines (+400/-421) 6 files modified tests/CMakeLists.txt (+1/-1) tests/eventually-fixture.h (+145/-0) tests/failure-test.cc (+6/-29) tests/libual-cpp-test.cc (+80/-170) tests/libual-test.cc (+59/-121) tests/zg-test.cc (+109/-100)
To merge this branch:	bzr merge lp://staging/~ted/ubuntu-app-launch/eventually-tests
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
dobey (community)		2016-08-06	Abstain on 2016-08-17
unity-api-1-bot	continuous-integration		Needs Fixing on 2016-08-17
Charles Kerr (community)			Approve on 2016-08-17
Review via email: mp+302201@code.staging.launchpad.net

Revision history for this message

unity-api-1-bot (unity-api-1-bot) wrote on 2016-08-06:

#

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/32/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~ted/ubuntu-app-launch/eventually-tests updated on 2016-08-06

243. By Ted Gould on 2016-08-06: Allow the starting count to come a little later

Revision history for this message

unity-api-1-bot (unity-api-1-bot) wrote on 2016-08-06:

#

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/33/rebuild

FAILED: Continuous integration, rev:243
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/33/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build/304/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/310
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-1-sourcepkg/release=vivid+overlay/239
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-1-sourcepkg/release=xenial+overlay/239
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-1-sourcepkg/release=yakkety/239
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=vivid+overlay/168
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=vivid+overlay/168/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/168/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=yakkety/168
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=yakkety/168/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=vivid+overlay/168/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/168
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/168/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=yakkety/168/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=vivid+overlay/168
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=vivid+overlay/168/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/168/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=yakkety/168
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=yakkety/168/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/33/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~ted/ubuntu-app-launch/eventually-tests updated on 2016-08-06

244. By Ted Gould on 2016-08-06: Make StartHelper more robust and observers

Revision history for this message

unity-api-1-bot (unity-api-1-bot) wrote on 2016-08-06:

#

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/34/rebuild

FAILED: Continuous integration, rev:244
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/34/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build/305/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/311
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-1-sourcepkg/release=vivid+overlay/240
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-1-sourcepkg/release=xenial+overlay/240
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-1-sourcepkg/release=yakkety/240
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=vivid+overlay/169/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/169
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/169/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=yakkety/169
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=yakkety/169/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=vivid+overlay/169/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/169/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=yakkety/169/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=vivid+overlay/169
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=vivid+overlay/169/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/169
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/169/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=yakkety/169
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=yakkety/169/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/34/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~ted/ubuntu-app-launch/eventually-tests updated on 2016-08-06

245. By Ted Gould on 2016-08-06: Put in a warning if we timeout in the eventually

Revision history for this message

unity-api-1-bot (unity-api-1-bot) wrote on 2016-08-06:

#

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/35/rebuild

FAILED: Continuous integration, rev:245
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/35/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build/306/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/312
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-1-sourcepkg/release=vivid+overlay/241
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-1-sourcepkg/release=xenial+overlay/241
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-1-sourcepkg/release=yakkety/241
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=vivid+overlay/170
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=vivid+overlay/170/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/170
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/170/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=yakkety/170/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=vivid+overlay/170/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/170/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=yakkety/170
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=yakkety/170/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=vivid+overlay/170
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=vivid+overlay/170/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/170
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/170/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=yakkety/170
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=yakkety/170/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/35/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~ted/ubuntu-app-launch/eventually-tests updated on 2016-08-06

246. By Ted Gould on 2016-08-06: Clear at the end of the test to ensure we get a flush

Revision history for this message

unity-api-1-bot (unity-api-1-bot) wrote on 2016-08-06:

#

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/36/rebuild

FAILED: Continuous integration, rev:246
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/36/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build/307/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/313
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-1-sourcepkg/release=vivid+overlay/242
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-1-sourcepkg/release=xenial+overlay/242
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-1-sourcepkg/release=yakkety/242
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=vivid+overlay/171
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=vivid+overlay/171/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/171/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=yakkety/171
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=yakkety/171/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=vivid+overlay/171/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/171/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=yakkety/171
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=yakkety/171/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=vivid+overlay/171
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=vivid+overlay/171/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/171
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/171/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=yakkety/171
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=yakkety/171/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/36/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~ted/ubuntu-app-launch/eventually-tests updated on 2016-08-07

247. By Ted Gould on 2016-08-07: Sure up the StopHelper functions
248. By Ted Gould on 2016-08-07: Give the Zeitgeist test the eventually treatment

Revision history for this message

unity-api-1-bot (unity-api-1-bot) wrote on 2016-08-07:

#

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/37/rebuild

FAILED: Continuous integration, rev:248
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/37/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build/308/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/314
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-1-sourcepkg/release=vivid+overlay/243
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-1-sourcepkg/release=xenial+overlay/243
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-1-sourcepkg/release=yakkety/243
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=vivid+overlay/172/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/172
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/172/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=yakkety/172/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=vivid+overlay/172/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/172/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=yakkety/172/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=vivid+overlay/172
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=vivid+overlay/172/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/172
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/172/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=yakkety/172
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=yakkety/172/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/37/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~ted/ubuntu-app-launch/eventually-tests updated on 2016-08-07

249. By Ted Gould on 2016-08-07: Remove the eventually calls, they don't actually work
250. By Ted Gould on 2016-08-07: Put a couple of pauses in

Revision history for this message

unity-api-1-bot (unity-api-1-bot) wrote on 2016-08-07:

#

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/38/rebuild

PASSED: Continuous integration, rev:250
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/38/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build/309
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/315
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-1-sourcepkg/release=vivid+overlay/244
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-1-sourcepkg/release=xenial+overlay/244
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-1-sourcepkg/release=yakkety/244
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=vivid+overlay/173
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=vivid+overlay/173/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/173
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/173/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=yakkety/173
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=yakkety/173/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=vivid+overlay/173
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=vivid+overlay/173/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/173
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/173/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=yakkety/173
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=yakkety/173/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=vivid+overlay/173
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=vivid+overlay/173/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/173
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/173/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=yakkety/173
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=yakkety/173/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/38/rebuild

review: Approve (continuous-integration)

lp://staging/~ted/ubuntu-app-launch/eventually-tests updated on 2016-08-07

251. By Ted Gould on 2016-08-07: Another commit to make Jenkins run again

Revision history for this message

unity-api-1-bot (unity-api-1-bot) wrote on 2016-08-07:

#

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/39/rebuild

PASSED: Continuous integration, rev:251
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/39/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build/310
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/316
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-1-sourcepkg/release=vivid+overlay/245
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-1-sourcepkg/release=xenial+overlay/245
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-1-sourcepkg/release=yakkety/245
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=vivid+overlay/174
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=vivid+overlay/174/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/174
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/174/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=yakkety/174
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=yakkety/174/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=vivid+overlay/174
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=vivid+overlay/174/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/174
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/174/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=yakkety/174
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=yakkety/174/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=vivid+overlay/174
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=vivid+overlay/174/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/174
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/174/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=yakkety/174
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=yakkety/174/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/39/rebuild

review: Approve (continuous-integration)

lp://staging/~ted/ubuntu-app-launch/eventually-tests updated on 2016-08-07

252. By Ted Gould on 2016-08-07: Formatting. Jenkins do it again.

Revision history for this message

unity-api-1-bot (unity-api-1-bot) wrote on 2016-08-07:

#

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/40/rebuild

PASSED: Continuous integration, rev:252
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/40/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build/311
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/317
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-1-sourcepkg/release=vivid+overlay/246
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-1-sourcepkg/release=xenial+overlay/246
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-1-sourcepkg/release=yakkety/246
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=vivid+overlay/175
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=vivid+overlay/175/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/175
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/175/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=yakkety/175
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=yakkety/175/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=vivid+overlay/175
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=vivid+overlay/175/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/175
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/175/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=yakkety/175
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=yakkety/175/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=vivid+overlay/175
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=vivid+overlay/175/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/175
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/175/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=yakkety/175
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=yakkety/175/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/40/rebuild

review: Approve (continuous-integration)

Revision history for this message

dobey (dobey) wrote on 2016-08-08:

#

Do we really want to get into the habit of copy+pasting code across multiple projects as a means of working around bad tests?

review: Needs Information

Revision history for this message

Ted Gould (ted) wrote on 2016-08-08:

#

On Mon, 2016-08-08 at 14:18 +0000, Rodney Dawes wrote:
> Do we really want to get into the habit of copy+pasting code across
> multiple projects as a means of working around bad tests?
We don't have a shared place to put it today. And it isn't a copy, only
really in spirit, though it is more generic in this instance.

Revision history for this message

Charles Kerr (charlesk) wrote on 2016-08-17:

#

About the patch iteself:

Coding comments inline.

I have a lot of comments and questions, a few needs fixings, but nothing that can't be churned through. In general I think this MR is an unambiguous improvement.

About Dobey's comment:

1. copy-paste: FWIW I've borrowed parts of the i-sound fixture for other indicators, cutting out the pieces I didn't need for the task at hand. So yes we already have a lot of slightly different versions of this floating around. We really do need a build-depends place for these things to live so that we can avoid lossy duplication.

2. "working around": _EVENTUALLY is an objectively better idiom than the tests' previous approach of hardcoding a sleep interval. With _EVENTUALLY you no longer have to find the goldilox sleep interval (sleep too little? tests fail on that 4bit MIPS box in the CI pool. sleep too much? tests take forever on your dev box).

3. Maybe I'm reading too much into the comment, but the implication I'm reading is that you're concerned this MR will make bad tests pass. If that's a concern, what are the runtime steps that would lead to that?

review: Needs Fixing

Revision history for this message

Ted Gould (ted) wrote on 2016-08-17:

#

Download full text (4.5 KiB)

On Wed, 2016-08-17 at 02:08 +0000, Charles Kerr wrote:
> > +    static gboolean timeout_cb(gpointer user_data)
> > +    {
> > +        GMainLoop *loop = static_cast<GMainLoop *>(user_data);
> type specified twice; use auto on lhs

Fixed r253

> > + void pause(unsigned int ms = 0)
> 1. is 0ms a meaningful default? What happens when you call
> g_timeout_add(0)?
>
> 2. is this called anywhere? If not, do we really need it?

Yes, it is used in libual tests. What it does is basically add an event
at the end of the event queue. So it'll flush all the events on the
mainloop that are currently queued.

> > + testing::AssertionResult
> > expectEventually(std::function<testing::AssertionResult(void)>
> > &testfunc)
> Slightly misleading function name as it doesn't `expect' in the gtest
> sense

r254

> > +        auto loop =
> > std::shared_ptr<GMainLoop>(g_main_loop_new(nullptr, FALSE),
> > [](GMainLoop *loop) {
> > +            if (loop != nullptr)
> > +                g_main_loop_unref(loop);
> 1. Are we really worried about g_main_loop_new(nullptr, false)
> returning nullptr? :)
>
> 2. (opinion) g_clear_pointer(&loop, g_main_loop_unref) is slightly
> cleaner

r255, you never know :-) I think the issue would be if someone called
reset on it twice.

> + std::function<int(void)> idlefunc = [&loop, &retpromise,
> > &testfunc, &start, this]() -> int {
> shouldn't the signature be <gboolean(void)> ?

Good catch r256

> > + if (result == false && _eventuallyTime >
> > (std::chrono::steady_clock::now() - start))
> 'result == false' called twice, here and below. Use a temp variable
> instead?
>
> 'std::chrono::steady_clock::now() - start' called twice, here and
> below. Use a temp variable instead?

r257

> + g_idle_add(
> (idle prattle) We really really need a lambda-friendly wrapper to
> g_idle_add() / g_timeout_add() et al

I kinda like the ones on glib-thread.h/cpp, we should figure out how to
have them work on the main thread as well. Topic for another branch :-)

> And to finish my point about the 'misleading function names' above, a
> bunch of ASSERT_EVENTUALLY_FOO() helpers could be added here with
> very little work.

r258

> > #include <future>
> > #include <thread>
> >
> > +#include "eventually-fixture.h"
> > +#include "mir-mock.h"
> > +#include <gio/gio.h>
> > #include <gtest/gtest.h>
> > -#include <gio/gio.h>
> > #include <zeitgeist.h>
> > -#include "mir-mock.h"
> >
> > -#include "registry.h"
> > #include "application.h"
> > #include "helper.h"
> > +#include "registry.h"
> These #includes are all over the place -- C++ system files, then
> local files, then other libraries' headers, then local files again.
>
> I don't want to be overly pedantic, but mixing local files around the
> #include section like this is too much :)
>
> Please follow the standard Names and Order of Includes guidelines.

r259

> For a discouraged function, AppID::operator std::string() sure shows
> up a lot

It is good for test suites.

> > + /* Not sure why, but this makes this test better, hopefully we
> > can
> That's pretty vague.
>
> I'm not opposed to it being handled in a separate MR, but could you
> do some due dili...

On Wed, 2016-08-17 at 02:08 +0000, Charles Kerr wrote:
> > +    static gboolean timeout_cb(gpointer user_data)
> > +    {
> > +        GMainLoop *loop = static_cast<GMainLoop *>(user_data);
> type specified twice; use auto on lhs

Fixed r253

> > +    void pause(unsigned int ms = 0)
> 1. is 0ms a meaningful default? What happens when you call
> g_timeout_add(0)?
> 
> 2. is this called anywhere? If not, do we really need it?

Yes, it is used in libual tests. What it does is basically add an event
at the end of the event queue. So it'll flush all the events on the
mainloop that are currently queued.

> > +    testing::AssertionResult
> > expectEventually(std::function<testing::AssertionResult(void)>
> > &testfunc)
> Slightly misleading function name as it doesn't `expect' in the gtest
> sense

r254

> > +        auto loop =
> > std::shared_ptr<GMainLoop>(g_main_loop_new(nullptr, FALSE),
> > [](GMainLoop *loop) {
> > +            if (loop != nullptr)
> > +                g_main_loop_unref(loop);
> 1. Are we really worried about g_main_loop_new(nullptr, false)
> returning nullptr? :)
> 
> 2. (opinion) g_clear_pointer(&loop, g_main_loop_unref) is slightly
> cleaner

r255, you never know :-)  I think the issue would be if someone called
reset on it twice.

> +        std::function<int(void)> idlefunc = [&loop, &retpromise,
> > &testfunc, &start, this]() -> int {
> shouldn't the signature be <gboolean(void)> ?

Good catch r256

> > +            if (result == false && _eventuallyTime >
> > (std::chrono::steady_clock::now() - start))
> 'result == false' called twice, here and below. Use a temp variable
> instead?
> 
> 'std::chrono::steady_clock::now() - start' called twice, here and
> below. Use a temp variable instead?

r257

> +        g_idle_add(
> (idle prattle) We really really need a lambda-friendly wrapper to
> g_idle_add() / g_timeout_add() et al

I kinda like the ones on glib-thread.h/cpp, we should figure out how to
have them work on the main thread as well. Topic for another branch :-)

> And to finish my point about the 'misleading function names' above, a
> bunch of ASSERT_EVENTUALLY_FOO() helpers could be added here with
> very little work.

r258

> >  #include <future>
> >  #include <thread>
> >  
> > +#include "eventually-fixture.h"
> > +#include "mir-mock.h"
> > +#include <gio/gio.h>
> >  #include <gtest/gtest.h>
> > -#include <gio/gio.h>
> >  #include <zeitgeist.h>
> > -#include "mir-mock.h"
> >  
> > -#include "registry.h"
> >  #include "application.h"
> >  #include "helper.h"
> > +#include "registry.h"
> These #includes are all over the place -- C++ system files, then
> local files, then other libraries' headers, then local files again.
> 
> I don't want to be overly pedantic, but mixing local files around the
> #include section like this is too much :)
> 
> Please follow the standard Names and Order of Includes guidelines.

r259

> For a discouraged function, AppID::operator std::string() sure shows
> up a lot

It is good for test suites.

> > +    /* Not sure why, but this makes this test better, hopefully we
> > can
> That's pretty vague.
> 
> I'm not opposed to it being handled in a separate MR, but could you
> do some due diligence here to explain the issue more than 'makes this
> test better'? :-)

Yes, looked into it further, it is the cancellables in second-exec.c
that are likely causing the issue.

> > +    EXPECT_EVENTUALLY_EQ(DBUS_TEST_TASK_STATE_RUNNING,
> > dbus_test_task_get_state(DBUS_TEST_TASK(cgmock2)));
> > +    EXPECT_EVENTUALLY_EQ(DBUS_TEST_TASK_STATE_RUNNING,
> > dbus_test_task_get_state(DBUS_TEST_TASK(zgmock)));
> This is a slightly different test. Before, you were testing A && B.
> Now you're testing eventually A, then eventually B

Actually not a test, we're just using this to ensure that both are
running before continuing the test. If they don't run, we want it to
show up in the results.

> > +static void zg_state_changed(DbusTestTask* task, DbusTestTaskState
> > state, gpointer user_data)
> > +{
> > +    DbusTestTaskState* outstate = (DbusTestTaskState*)user_data;
> 1. C style cast
> 
> 2. Type specified twice. Suggest auto on lhs.

r260

> > +    g_setenv("APP_ID", "foo", 1);
> s/1/true/
>

r261

> > +    ASSERT_NE(calls, nullptr);
> > +    ASSERT_EQ(numcalls, 1);
> The two lines above should take expected as first arg, actual as
> second

r262

> > 
> > +    EXPECT_LT(end - start, 14 * 1000 * 1000);
> This seems unneeded now, since the new EXPECT_EVENTUALLY_EQ() call
> will warn on timeout a few lines above
>

Yeah, makes sense. r263

lp://staging/~ted/ubuntu-app-launch/eventually-tests updated on 2016-08-17

253. By Ted Gould on 2016-08-17: Going on auto
254. By Ted Gould on 2016-08-17: Switch function name to better describe what it does
255. By Ted Gould on 2016-08-17: Switch to g_clear_pointer()
256. By Ted Gould on 2016-08-17: Change return type to gboolean
257. By Ted Gould on 2016-08-17: Capture temporary variables
258. By Ted Gould on 2016-08-17: Add some assert defines
259. By Ted Gould on 2016-08-17: Sort includes
260. By Ted Gould on 2016-08-17: Change to C++ style declaration
261. By Ted Gould on 2016-08-17: Pass TRUE to setenv
262. By Ted Gould on 2016-08-17: Fix assert ordering
263. By Ted Gould on 2016-08-17: Remove timing other than eventually

Revision history for this message

unity-api-1-bot (unity-api-1-bot) wrote on 2016-08-17:

#

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/54/rebuild

PASSED: Continuous integration, rev:263
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/54/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build/391
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/397
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-1-sourcepkg/release=vivid+overlay/312
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-1-sourcepkg/release=xenial+overlay/312
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-1-sourcepkg/release=yakkety/312
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=vivid+overlay/242
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=vivid+overlay/242/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/242
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/242/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=yakkety/242
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=yakkety/242/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=vivid+overlay/242
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=vivid+overlay/242/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/242
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/242/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=yakkety/242
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=yakkety/242/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=vivid+overlay/242
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=vivid+overlay/242/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/242
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/242/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=yakkety/242
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=yakkety/242/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/54/rebuild

review: Approve (continuous-integration)

lp://staging/~ted/ubuntu-app-launch/eventually-tests updated on 2016-08-17

264. By Ted Gould on 2016-08-17: Fix return type of cast
265. By Ted Gould on 2016-08-17: Cleaning up comments

Revision history for this message

Charles Kerr (charlesk) wrote on 2016-08-17:

#

Good stuff.

review: Approve

Revision history for this message

unity-api-1-bot (unity-api-1-bot) wrote on 2016-08-17:

#

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/57/rebuild

FAILED: Continuous integration, rev:264
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/57/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build/394/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/400
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-1-sourcepkg/release=vivid+overlay/315
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-1-sourcepkg/release=xenial+overlay/315
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-1-sourcepkg/release=yakkety/315
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=vivid+overlay/245
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=vivid+overlay/245/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/245
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/245/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=yakkety/245
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=yakkety/245/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=vivid+overlay/245
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=vivid+overlay/245/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/245
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/245/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=yakkety/245
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=yakkety/245/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=vivid+overlay/245/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/245
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/245/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=yakkety/245
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=yakkety/245/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/57/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

dobey (dobey) on 2016-08-17:

#

review: Abstain

Ubuntu Application Launcher

Merge lp://staging/~ted/ubuntu-app-launch/eventually-tests into lp://staging/ubuntu-app-launch/16.10

Commit message

Description of the change

Preview Diff

Subscribers