Ubuntu Application Launcher

Merge lp://staging/~ted/ubuntu-app-launch/disable-handshake-wait into lp://staging/ubuntu-app-launch/16.10

  1. disable-handshake-wait
  2. Merge into trunk.16.10
Proposed by Ted Gould
Status: Merged
Approved by: Charles Kerr
Approved revision: 251
Merged at revision: 248
Proposed branch: lp://staging/~ted/ubuntu-app-launch/disable-handshake-wait
Merge into: lp://staging/ubuntu-app-launch/16.10
Diff against target: 257 lines (+53/-17)
11 files modified
helpers.c (+2/-2)
helpers.h (+2/-1)
libubuntu-app-launch/application-impl-click.cpp (+3/-3)
libubuntu-app-launch/click-exec.c (+2/-2)
libubuntu-app-launch/click-exec.h (+1/-1)
libubuntu-app-launch/desktop-exec.c (+2/-2)
libubuntu-app-launch/desktop-exec.h (+1/-1)
libubuntu-app-launch/registry-impl.cpp (+22/-1)
libubuntu-app-launch/registry-impl.h (+6/-0)
libubuntu-app-launch/ubuntu-app-launch.cpp (+10/-2)
tests/helper-handshake-test.cc (+2/-2)
To merge this branch: bzr merge lp://staging/~ted/ubuntu-app-launch/disable-handshake-wait
Reviewer Review Type Date Requested Status
Charles Kerr (community) Approve
unity-api-1-bot continuous-integration Needs Fixing
Review via email: mp+304790@code.staging.launchpad.net

Commit message

Disable handshake wait with clients doing handshaking

Description of the change

Make it so that when an application registers to get application startup signals we stop waiting on responses for cases where its mainloop is blocked and might not be able to send them.

To post a comment you must log in.
Revision history for this message
unity-api-1-bot (unity-api-1-bot) wrote :

FAILED: Continuous integration, rev:251
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/91/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build/546/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/552
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=vivid+overlay/389/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/389
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/389/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=yakkety/389/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=vivid+overlay/389/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/389/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=yakkety/389/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=vivid+overlay/389/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/389/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=yakkety/389/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/91/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Charles Kerr (charlesk) wrote :

Looks like a reasonable change for the workaround, agree wrt this being better as a nonstatic in the future.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches