Ubuntu Application Launcher

Merge lp://staging/~ted/ubuntu-app-launch/correct-desktop-hook into lp://staging/ubuntu-app-launch/14.10

  1. correct-desktop-hook
  2. Merge into trunk.14.10
Proposed by Ted Gould
Status: Work in progress
Proposed branch: lp://staging/~ted/ubuntu-app-launch/correct-desktop-hook
Merge into: lp://staging/ubuntu-app-launch/14.10
Prerequisite: lp://staging/~ted/ubuntu-app-launch/proper-job-test
Diff against target: 16 lines (+9/-0)
1 file modified
tests/manual (+9/-0)
To merge this branch: bzr merge lp://staging/~ted/ubuntu-app-launch/correct-desktop-hook
Reviewer Review Type Date Requested Status
Allan LeSage Needs Fixing
PS Jenkins bot (community) continuous-integration Needs Fixing
Review via email: mp+222555@code.staging.launchpad.net

Commit message

Test for desktop files being created correctly

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:157
http://jenkins.qa.ubuntu.com/job/upstart-app-launch-ci/272/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/upstart-app-launch-utopic-amd64-ci/11
    FAILURE: http://jenkins.qa.ubuntu.com/job/upstart-app-launch-utopic-armhf-ci/11/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/upstart-app-launch-utopic-i386-ci/11

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/upstart-app-launch-ci/272/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
Allan LeSage (allanlesage) wrote :

More detail on ll. 14-15, can you cook up a one-liner for each? The explanation plus a cut-and-pasteable enables a tester to understand and saves labor, also shortcuts to an integration test which is sure to follow. . . .

review: Needs Fixing
Reply

Unmerged revisions

157. By Ted Gould

Use the same key desktop hook is using

156. By Ted Gould

Adding a test for the desktop cache

155. By Ted Gould

Grabbing the job test

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches