Merge lp://staging/~ted/ubuntu-app-launch/bad-appid-recoverable-error into lp://staging/ubuntu-app-launch/14.04

Proposed by Ted Gould
Status: Merged
Approved by: Charles Kerr
Approved revision: 151
Merged at revision: 147
Proposed branch: lp://staging/~ted/ubuntu-app-launch/bad-appid-recoverable-error
Merge into: lp://staging/ubuntu-app-launch/14.04
Diff against target: 286 lines (+235/-2)
5 files modified
CMakeLists.txt (+1/-1)
desktop-exec.c (+42/-1)
libupstart-app-launch/upstart-app-launch.c (+1/-0)
recoverable-problem.c (+165/-0)
recoverable-problem.h (+26/-0)
To merge this branch: bzr merge lp://staging/~ted/ubuntu-app-launch/bad-appid-recoverable-error
Reviewer Review Type Date Requested Status
Charles Kerr (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+216192@code.staging.launchpad.net

Commit message

More elegant handling of bad application id errors

Description of the change

We get various bugs on this, which is good that they're being reported, but there's a bit of noise. Trying to filter out that noise and be a bit more sophisticated on the reporting.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Charles Kerr (charlesk) wrote :

* cmdline is leaked.

* Not a blocker for this merge, but as a general comment: we really need to move recoverable-problem.c into some shared location

Revision history for this message
Charles Kerr (charlesk) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches