Merge lp://staging/~ted/snapcraft/python-pip into lp://staging/~snappy-dev/snapcraft/core
Proposed by
Ted Gould
Status: | Merged |
---|---|
Approved by: | Sergio Schvezov |
Approved revision: | 159 |
Merged at revision: | 178 |
Proposed branch: | lp://staging/~ted/snapcraft/python-pip |
Merge into: | lp://staging/~snappy-dev/snapcraft/core |
Diff against target: |
237 lines (+95/-11) 11 files modified
integration-tests/data/pip-requirements/icon.svg (+2/-0) integration-tests/data/pip-requirements/requirements.txt (+1/-0) integration-tests/data/pip-requirements/snapcraft.yaml (+14/-0) integration-tests/units/jobs.pxu (+11/-0) plugins/python2.yaml (+3/-0) plugins/python3.yaml (+3/-0) snapcraft/plugins/python2.py (+25/-0) snapcraft/plugins/python2_project.py (+2/-5) snapcraft/plugins/python3.py (+25/-0) snapcraft/plugins/python3_project.py (+5/-4) snapcraft/yaml.py (+4/-2) |
To merge this branch: | bzr merge lp://staging/~ted/snapcraft/python-pip |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Sergio Schvezov | Approve | ||
Review via email:
|
Commit message
Add in support for PIP requirements.txt files in the python plugins.
Description of the change
Add in support for PIP requirements.txt files in the python plugins.
To post a comment you must log in.
Are you rendering the py3 and py2 examples useless here by removing handle_source options?
I also bring this question up often enough (internally at least); with this implemented in python instead of python-project, what is the reason for python-project (or any .*-project at all?)