Snapcraft

Merge lp://staging/~ted/snapcraft/autoreconf into lp://staging/~snappy-dev/snapcraft/core

  1. autoreconf
  2. Merge into core
Proposed by Ted Gould
Status: Merged
Approved by: Ted Gould
Approved revision: 249
Merged at revision: 245
Proposed branch: lp://staging/~ted/snapcraft/autoreconf
Merge into: lp://staging/~snappy-dev/snapcraft/core
Diff against target: 35 lines (+9/-2)
2 files modified
snapcraft/plugins/autotools.py (+8/-2)
snapcraft/yaml.py (+1/-0)
To merge this branch: bzr merge lp://staging/~ted/snapcraft/autoreconf
Reviewer Review Type Date Requested Status
Sergio Schvezov Approve
Ted Gould Pending
Review via email: mp+274893@code.staging.launchpad.net

This proposal supersedes a proposal from 2015-10-19.

Commit message

Fixes needed for some autotools builds

Description of the change

When working on the Ginac example, the build didn't do well without more fixes.

To post a comment you must log in.
Revision history for this message
Sergio Schvezov (sergiusens) wrote :

Looks good, can you create bug, add it to milestone 0.4 and link to it?

Revision history for this message
Sergio Schvezov (sergiusens) :
review: Approve
Revision history for this message
Snappy Tarmac (snappydevtarmac) wrote :

The attempt to merge lp:~ted/snapcraft/autoreconf into lp:snapcraft failed. Below is the output from the failed tests.

snapcraft/plugins/autotools.py:50:80: E501 line too long (93 > 79 characters)

lp://staging/~ted/snapcraft/autoreconf updated
249. By Ted Gould

PEP8 Fixes

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: