Merge lp://staging/~ted/policykit-unity8/lp1579837-no-exception-on-timeout into lp://staging/policykit-unity8
Proposed by
Ted Gould
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Charles Kerr | ||||
| Approved revision: | 13 | ||||
| Merged at revision: | 7 | ||||
| Proposed branch: | lp://staging/~ted/policykit-unity8/lp1579837-no-exception-on-timeout | ||||
| Merge into: | lp://staging/policykit-unity8 | ||||
| Diff against target: |
25 lines (+12/-3) 1 file modified
service/authentication.cpp (+12/-3) |
||||
| To merge this branch: | bzr merge lp://staging/~ted/policykit-unity8/lp1579837-no-exception-on-timeout | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Charles Kerr (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Replacing that U8 isn't responding with a recoverable error instead of crashing
Description of the change
Make it so that it doesn't look like our fault, but we still figure out issues :-)
To post a comment you must log in.
Revision history for this message
| Charles Kerr (charlesk) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Adding in commented-out lines to debian/ is pretty clumsy.
IMO this would be better with the try-catch for now and adding the whoopsie pieces once the whoopsie FTBFS is resolved.