Merge lp://staging/~ted/libertine/qtdbus-connection into lp://staging/libertine/trunk

Proposed by Ted Gould
Status: Rejected
Rejected by: Christopher Townsend
Proposed branch: lp://staging/~ted/libertine/qtdbus-connection
Merge into: lp://staging/libertine/trunk
Diff against target: 163 lines (+45/-34)
3 files modified
liblibertine/libertined.cpp (+31/-15)
python/libertine/ContainersConfig.py (+13/-14)
tools/libertine-container-manager (+1/-5)
To merge this branch: bzr merge lp://staging/~ted/libertine/qtdbus-connection
Reviewer Review Type Date Requested Status
Christopher Townsend (community) Disapprove
Review via email: mp+317237@code.staging.launchpad.net

Commit message

Ensure we don't leak references to the DBus session bus.

To post a comment you must log in.
Revision history for this message
Christopher Townsend (townsend) wrote :

This was branched from lp:libertine instead of lp:libertine/trunk and we needed a fixed branch quickly, so I made https://code.launchpad.net/~townsend/libertine/qtdbus-connection/+merge/317244 to remedy that.

No need for this MP anymore.

review: Disapprove

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches