libappindicator

Merge lp://staging/~ted/libappindicator/unity-parser into lp://staging/libappindicator/13.10

  1. unity-parser
  2. Merge into trunk.13.10
Proposed by Ted Gould
Status: Work in progress
Proposed branch: lp://staging/~ted/libappindicator/unity-parser
Merge into: lp://staging/libappindicator/13.10
Prerequisite: lp://staging/~ted/libappindicator/saucy-fix
Diff against target: 818 lines (+333/-157)
8 files modified
configure.ac (+2/-2)
debian/control (+2/-3)
example/simple-client.c (+0/-2)
src/app-indicator.c (+283/-84)
src/app-indicator.h (+0/-4)
src/notification-item.xml (+2/-0)
tests/test-libappindicator.c (+35/-55)
tests/test-simple-app.c (+9/-7)
To merge this branch: bzr merge lp://staging/~ted/libappindicator/unity-parser
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Indicator Applet Developers Pending
Review via email: mp+168286@code.staging.launchpad.net

This proposal supersedes a proposal from 2013-05-02.

Commit message

Convert from DBusMenu to GMenu

Description of the change

Changing the backend of libappindicator to be based on GMenuModel instead of DBusmenu.

Pushing this up for review and people to start looking at, but if it lands the world will end. Okay, probably not that, but nothing will work as indicator-application needs to be updated first.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:277
http://jenkins.qa.ubuntu.com/job/libappindicator-ci/8/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/libappindicator-raring-amd64-ci/9/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/libappindicator-ci/8/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Charles Kerr (charlesk) wrote : Posted in a previous version of this proposal

> Pushing this up for review and people to start looking at, but if it lands the world will end.

Some people just want to watch the world burn. APPROVE

Revision history for this message
Ted Gould (ted) wrote : Posted in a previous version of this proposal

Okay, I think I'm happy with this now. Had to clean up some of the action groups stuff. But it should work in most cases now. Next rev we can add a way to put GMenu/GActionGroups in with supported functions. For now we just need to support the old API.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:289
http://jenkins.qa.ubuntu.com/job/libappindicator-ci/10/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/libappindicator-raring-amd64-ci/11/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/libappindicator-ci/10/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Ted Gould (ted) wrote : Posted in a previous version of this proposal

Wanted to note here so no one else investigates that the reason Jenkins is failing is because Raring doesn't have the required dependencies. They are in Saucy and the job is on the list to be updated.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:289
http://jenkins.qa.ubuntu.com/job/libappindicator-ci/11/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/libappindicator-saucy-amd64-ci/1/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/libappindicator-ci/11/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Ted Gould (ted) wrote :

Rebased on the saucy fix to see if we can make Jenkins happy.

Reply
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:289
http://jenkins.qa.ubuntu.com/job/libappindicator-ci/15/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/libappindicator-saucy-amd64-ci/5/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/libappindicator-ci/15/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:289
http://jenkins.qa.ubuntu.com/job/libappindicator-ci/16/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/libappindicator-saucy-amd64-ci/6

Click here to trigger a rebuild:
http://s-jenkins:8080/job/libappindicator-ci/16/rebuild

review: Approve (continuous-integration)
Reply

Unmerged revisions

289. By Ted Gould

Blocking a silly warning that isn't useful. Remember this when commenting on the quality of the GLib API.

288. By Ted Gould

Make GTK doc happy

287. By Ted Gould

Upgrade to a pop culture reference

286. By Ted Gould

Handling the debug property using boxed types

285. By Ted Gould

Switch over to using the ActionInfo array

284. By Ted Gould

Putting the bus stuff in the action info structure

283. By Ted Gould

Adds in a structure and an array so that we can start tracking action groups as a set

282. By Ted Gould

Fixing some docs errors

281. By Ted Gould

Adding support for the properties in their current form.

280. By Ted Gould

Add properties for the GMenuModels

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches