The Sound Menu

Merge lp://staging/~ted/indicator-sound/lp1399862-active-port-null into lp://staging/indicator-sound/15.04

  1. lp1399862-active-port-null
  2. Merge into trunk.15.04
Proposed by Ted Gould
Status: Merged
Approved by: Ted Gould
Approved revision: 464
Merged at revision: 472
Proposed branch: lp://staging/~ted/indicator-sound/lp1399862-active-port-null
Merge into: lp://staging/indicator-sound/15.04
Diff against target: 18 lines (+4/-4)
1 file modified
src/volume-control.vala (+4/-4)
To merge this branch: bzr merge lp://staging/~ted/indicator-sound/lp1399862-active-port-null
Reviewer Review Type Date Requested Status
Antti Kaijanmäki (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+243898@code.staging.launchpad.net

Commit message

Ensure that the active port is not null before looking at its value

Description of the change

Not all values are non-null

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:463
http://jenkins.qa.ubuntu.com/job/indicator-sound-ci/179/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-sound-vivid-amd64-ci/6
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-sound-vivid-armhf-ci/6
        deb: http://jenkins.qa.ubuntu.com/job/indicator-sound-vivid-armhf-ci/6/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-sound-ci/179/rebuild

review: Approve (continuous-integration)
Revision history for this message
Antti Kaijanmäki (kaijanmaki) wrote :

LGTM.

review: Approve
lp://staging/~ted/indicator-sound/lp1399862-active-port-null updated
464. By Ted Gould

Merge trunk

Revision history for this message
Ted Gould (ted) wrote :

Sync to trunk, resetting version number.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches