The Sound Menu

Merge lp://staging/~ted/indicator-sound/greeter-control into lp://staging/indicator-sound/14.04

greeter-control
Merge into trunk.14.04

Proposed by Ted Gould on 2014-03-04

Status:	Merged
Approved by:	Charles Kerr on 2014-03-14
Approved revision:	463
Merged at revision:	434
Proposed branch:	lp://staging/~ted/indicator-sound/greeter-control
Merge into:	lp://staging/indicator-sound/14.04
Prerequisite:	lp://staging/~ted/indicator-sound/account-service-player
Diff against target:	253 lines (+142/-3) 5 files modified debian/control (+2/-0) src/CMakeLists.txt (+5/-0) src/accounts-service-user.vala (+42/-0) src/greeter-broadcast.vala (+34/-0) src/media-player-user.vala (+59/-3)
To merge this branch:	bzr merge lp://staging/~ted/indicator-sound/greeter-control
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Charles Kerr (community)		2014-03-04	Approve on 2014-03-14
PS Jenkins bot (community)	continuous-integration		Needs Fixing on 2014-03-13
Review via email: mp+209338@code.staging.launchpad.net

Commit message

Allow the phone greeter player to control the running player in the session.

Description of the change

Puts both the sender and the listener of the greeter broadcast into both sides of the indicator-sound world. One emits the event through the reflector and the other receives it. Needs this branch to work:

https://code.launchpad.net/~ted/unity-greeter-session-broadcast/sound-control/+merge/208894

lp://staging/~ted/indicator-sound/greeter-control updated on 2014-03-05

459. By Ted Gould on 2014-03-05: Try to get session broadcast if we can
460. By Ted Gould on 2014-03-05: Grab accounts service too

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-03-05:

FAILED: Continuous integration, rev:458
http://jenkins.qa.ubuntu.com/job/indicator-sound-ci/103/
Executed test runs:
FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-sound-trusty-amd64-ci/43/console
FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-sound-trusty-armhf-ci/42/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-sound-ci/103/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-03-05:

FAILED: Continuous integration, rev:460
http://jenkins.qa.ubuntu.com/job/indicator-sound-ci/105/
Executed test runs:
FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-sound-trusty-amd64-ci/45/console
FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-sound-trusty-armhf-ci/44/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-sound-ci/105/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Charles Kerr (charlesk) wrote on 2014-03-12:

* Is Recommends sufficient for accountsservice? Surely it's a Depends now...?

* In GreeterBroadcast, RequestApplicationStart(), RequestHomeShown(), StartApplication(),
ShowHome() appear to be unused. Is there another branch waiting to be stacked on top
of this one? Otherwise, these unused methods/signals should be removed

* In accounts-service-user, probably ought to Warn() if username != g_get_user_name()
instead of returning silently... if that argument's wrong, something's gone wrong
in MediaPlayerListGreeter

lp://staging/~ted/indicator-sound/greeter-control updated on 2014-03-13

461. By Ted Gould on 2014-03-13: Don't build proxy for unused functions

Revision history for this message

Ted Gould (ted) wrote on 2014-03-13:

* Is Recommends sufficient for accountsservice? Surely it's a Depends now...?

I left it as a recommends just because we wouldn't *die* without it. I'd go either way, I figured the only thing we *needed* was the lib which gets pulled in by linking.

Fixed. r461. I commented them in case someone wanted to steal this Vala code in the future.

* In accounts-service-user, probably ought to Warn() if username != g_get_user_name()
instead of returning silently... if that argument's wrong, something's gone wrong
in MediaPlayerListGreeter

Those are the signals that come off the system bus, so those events can be targeted at another user session that is also running at the same time. So it can be normal that we'd get ones that aren't for us.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-03-13:

FAILED: Continuous integration, rev:461
http://jenkins.qa.ubuntu.com/job/indicator-sound-ci/108/
Executed test runs:
FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-sound-trusty-amd64-ci/48/console
FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-sound-trusty-armhf-ci/47/console