The Sound Menu

Merge lp://staging/~ted/indicator-sound/deduplicate-with-reason into lp://staging/indicator-sound/15.04

  1. deduplicate-with-reason
  2. Merge into trunk.15.04
Proposed by Ted Gould
Status: Merged
Approved by: Ted Gould
Approved revision: 493
Merged at revision: 493
Proposed branch: lp://staging/~ted/indicator-sound/deduplicate-with-reason
Merge into: lp://staging/indicator-sound/15.04
Diff against target: 50 lines (+21/-19)
1 file modified
src/volume-control-pulse.vala (+21/-19)
To merge this branch: bzr merge lp://staging/~ted/indicator-sound/deduplicate-with-reason
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Ricardo Salveti (community) Approve
Review via email: mp+256698@code.staging.launchpad.net

Commit message

Always record the volume whether we do something with it or not (LP: #1446703)

Description of the change

Make sure we always store the updated reason so we don't get notifications for extra events.

To post a comment you must log in.
Revision history for this message
Ricardo Salveti (rsalveti) wrote :

Looks good, fix a regression introduced by my previous change (my bad).

review: Approve
Revision history for this message
Ted Gould (ted) wrote :

Putting back to Needs Approval so that Jenkins will build a package.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:493
http://jenkins.qa.ubuntu.com/job/indicator-sound-ci/223/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-sound-vivid-amd64-ci/50
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-sound-vivid-armhf-ci/50
        deb: http://jenkins.qa.ubuntu.com/job/indicator-sound-vivid-armhf-ci/50/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-sound-ci/223/rebuild

review: Approve (continuous-integration)
Revision history for this message
Ted Gould (ted) wrote :

Switching back to Approved now that we have a deb that people can test with.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches