Merge into trunk.16.10 : systemd-unit : Code : Bluetooth Menu

Status:	Merged
Approved by:	Martin Pitt on 2016-10-21
Approved revision:	100
Merged at revision:	100
Proposed branch:	lp://staging/~ted/indicator-bluetooth/systemd-unit
Merge into:	lp://staging/indicator-bluetooth
Diff against target:	77 lines (+28/-0) 5 files modified configure.ac (+2/-0) data/Makefile.am (+15/-0) data/indicator-bluetooth.override (+1/-0) data/indicator-bluetooth.service.in (+8/-0) debian/control (+2/-0)
To merge this branch:	bzr merge lp://staging/~ted/indicator-bluetooth/systemd-unit
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Martin Pitt		2016-07-18	Approve on 2016-10-21
unity-api-1-bot	continuous-integration		Approve on 2016-09-12
PS Jenkins bot	continuous-integration		Pending
Review via email: mp+300358@code.staging.launchpad.net

lp://staging/~ted/indicator-bluetooth/systemd-unit updated on 2016-07-20

99. By Ted Gould on 2016-07-19: Install dep on indicator-common
100. By Ted Gould on 2016-07-20: Adding a restart rule

Revision history for this message

unity-api-1-bot (unity-api-1-bot) wrote on 2016-09-12:

#

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-indicator-bluetooth-ci/1/rebuild

PASSED: Continuous integration, rev:100
https://jenkins.canonical.com/unity-api-1/job/lp-indicator-bluetooth-ci/1/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build/607
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/613
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=vivid+overlay/437
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=vivid+overlay/437/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/437
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/437/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=yakkety/437
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=yakkety/437/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=vivid+overlay/437
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=vivid+overlay/437/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/437
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/437/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=yakkety/437
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=yakkety/437/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=vivid+overlay/437
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=vivid+overlay/437/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/437
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/437/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=yakkety/437
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=yakkety/437/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-indicator-bluetooth-ci/1/rebuild

review: Approve (continuous-integration)

Revision history for this message

Martin Pitt (pitti) wrote on 2016-10-21:

#

Same @pkglibexec@ typo, otherwise LGTM.

review: Needs Fixing

Revision history for this message

Martin Pitt (pitti) wrote on 2016-10-21:

#

Fixed the typo in https://code.launchpad.net/~pitti/indicator-bluetooth/fix-systemd-unit/+merge/309002 and added it to https://bileto.ubuntu.com/#/ticket/1710, so with that this is now okay.

review: Approve

lp://staging/~ted/indicator-bluetooth/systemd-unit updated on 2016-10-22

101. By Ted Gould on 2016-10-22: Merging trunk
102. By Ted Gould on 2016-10-22: Fix variable name

Revision history for this message

Ted Gould (ted) wrote on 2016-10-22:

#

On Fri, 2016-10-21 at 09:43 +0000, Martin Pitt wrote:
> Same @pkglibexec@ typo, otherwise LGTM.
Updated

Revision history for this message

Martin Pitt (pitti) wrote on 2016-10-23:

#

Oops, ok. So I'll remove https://code.launchpad.net/~pitti/indicator-bluetooth/fix-systemd-unit/+merge/309002 and rebuild the silo.

Bluetooth Menu

Merge lp://staging/~ted/indicator-bluetooth/systemd-unit into lp://staging/indicator-bluetooth

Commit message

Description of the change

Preview Diff

Subscribers