Merge lp://staging/~ted/dbus-test-runner/reporting-delay into lp://staging/dbus-test-runner/12.10

Proposed by Ted Gould
Status: Merged
Approved by: Ted Gould
Approved revision: 56
Merged at revision: 45
Proposed branch: lp://staging/~ted/dbus-test-runner/reporting-delay
Merge into: lp://staging/dbus-test-runner/12.10
Diff against target: 392 lines (+73/-39)
11 files modified
libdbustest/Makefile.am (+1/-1)
libdbustest/bustle.c (+21/-8)
libdbustest/process.c (+27/-8)
libdbustest/service.c (+5/-5)
libdbustest/task.c (+1/-1)
src/Makefile.am (+1/-1)
src/dbus-test-runner.c (+7/-7)
tests/Makefile.am (+5/-6)
tests/test-bustle-data-check.sh (+3/-0)
tests/test-bustle-list.sh (+1/-1)
tests/test-bustle.reference (+1/-1)
To merge this branch: bzr merge lp://staging/~ted/dbus-test-runner/reporting-delay
Reviewer Review Type Date Requested Status
jenkins (community) continuous-integration Approve
Charles Kerr (community) Approve
Review via email: mp+127375@code.staging.launchpad.net

Commit message

Adding a clearing of the buffers to make tests pass on slow systems

Description of the change

Setting up the dispose function so that it clears the buffers when complete to make sure we get a full log out. This should hopefully make it so that the tests pass even when Jenkins is busy doing other things at the same time.

Didn't realize when I started, but the bustle test is failing in trunk. So I fixed that along the way. Which then, lead me to realize that the bustle test data test wasn't actually checking its data. So I fixed that too. End of the day, this should make the test suite in good shape.

To post a comment you must log in.
Revision history for this message
jenkins (martin-mrazik+qa) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Allan LeSage (allanlesage) wrote :

Hey great incentive to fix a couple of failing tests not related to this MP, eh :) ?

53. By Ted Gould

Adding glib explicitly, seems to be failing for Jenkins

54. By Ted Gould

Trying to turn on -Wextra to figure out what's up with Jenkins. Don't think there's huge value, but might as well commit.

55. By Ted Gould

Same treatment for /src

Revision history for this message
jenkins (martin-mrazik+qa) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Charles Kerr (charlesk) wrote :

g_io_channel_read_line() always nul-terminates the string, so you don't need to do it manually. The rest of the new dispose code is fine.

I've no opinion on -Wextra but looks like it's not hurting anything.... :)

review: Approve
56. By Ted Gould

Stop putting in terminators. You can have too much of a good thing

Revision history for this message
jenkins (martin-mrazik+qa) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
jenkins (martin-mrazik+qa) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
jenkins (martin-mrazik+qa) wrote :
review: Approve (continuous-integration)
Revision history for this message
Allan LeSage (allanlesage) wrote :

Sorry for the spam--the "passed" result is correct :) .

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches