Landscape Client

Merge lp://staging/~tealeg/landscape-client/stop-truncating-explanatory-text into lp://staging/~landscape/landscape-client/trunk

  1. stop-truncating-explanatory-text
  2. Merge into trunk
Proposed by Geoff Teale
Status: Merged
Approved by: Geoff Teale
Approved revision: 790
Merged at revision: 791
Proposed branch: lp://staging/~tealeg/landscape-client/stop-truncating-explanatory-text
Merge into: lp://staging/~landscape/landscape-client/trunk
Diff against target: 171 lines (+3/-31)
1 file modified
landscape/ui/view/ui/landscape-client-settings.glade (+3/-31)
To merge this branch: bzr merge lp://staging/~tealeg/landscape-client/stop-truncating-explanatory-text
Reviewer Review Type Date Requested Status
Björn Tillenius (community) Approve
Benji York (community) Approve
Review via email: mp+237746@code.staging.launchpad.net

Commit message

Modify the Glade XML so that the landscape-client-ui doesn't truncate
the warning message when "None" is selected on the dropdown.

Description of the change

Modify the Glade XML so that the landscape-client-ui doesn't truncate
the warning message when "None" is selected on the dropdown.

To post a comment you must log in.
Revision history for this message
Benji York (benji) wrote :

The code looks fine, but I can't figure out how to actually see the UI itself. I'd usually list the things I've tried, but I've tried so many things that listing them is probably counter-productive.

How do I test the UI?

Thanks.

review: Needs Information
Revision history for this message
Geoff Teale (tealeg) wrote :

Hi Benji,

There are two ways. Either build the landscape-client debian packages and install landscape-client-setting-ui, or install the current version and simply overwrite the glade file that's installed with the new glade file.

Top tip, that file lives here:

/usr/lib/python2.7/dist-packages/landscape/ui/view/ui/landscape-client-settings.glade

Once you've done either of the above, just go to your system settings panel and hit that landscape icon!

Revision history for this message
Benji York (benji) wrote :

Thanks for the info. I never could get the package to build. I suspect it takes more than just "make package", but I swapped the glade file in and it looked good.

Thanks for the fix.

review: Approve
Revision history for this message
Björn Tillenius (bjornt) wrote :

+1. I didn't test it, but I trust that both you and Benji tested it.

review: Approve
Revision history for this message
Geoff Teale (tealeg) wrote :

Cheers Björn. I did indeed test it, and it seems that Benji did too.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: