Merge lp://staging/~tealeg/landscape-client/notify-on-script-output-truncation into lp://staging/~landscape/landscape-client/trunk

Proposed by Geoff Teale
Status: Merged
Approved by: Geoff Teale
Approved revision: 927
Merged at revision: 923
Proposed branch: lp://staging/~tealeg/landscape-client/notify-on-script-output-truncation
Merge into: lp://staging/~landscape/landscape-client/trunk
Diff against target: 125 lines (+54/-11)
2 files modified
landscape/manager/scriptexecution.py (+19/-7)
landscape/manager/tests/test_scriptexecution.py (+35/-4)
To merge this branch: bzr merge lp://staging/~tealeg/landscape-client/notify-on-script-output-truncation
Reviewer Review Type Date Requested Status
🤖 Landscape Builder test results Approve
Adam Collard (community) Approve
Alberto Donato Approve
Review via email: mp+307215@code.staging.launchpad.net

Commit message

Add an indication of truncation to process output that has been truncated prior to delivery to the server.

Description of the change

Add an indication of truncation to process output that has been truncated prior to delivery to the server.

Testing instructions:

Run the test suite ;-)

To post a comment you must log in.
Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: TRIAL_ARGS=-j4 make check
Result: Fail
Revno: 923
Branch: lp:~tealeg/landscape-client/notify-on-script-output-truncation
Jenkins: https://ci.lscape.net/job/latch-test-precise/126/

review: Needs Fixing (test results)
Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: TRIAL_ARGS=-j4 make check
Result: Success
Revno: 924
Branch: lp:~tealeg/landscape-client/notify-on-script-output-truncation
Jenkins: https://ci.lscape.net/job/latch-test-precise/127/

review: Approve (test results)
Revision history for this message
Alberto Donato (ack) wrote :

+1 looks good.

Just a nit inline.

review: Approve
Revision history for this message
Adam Collard (adam-collard) :
review: Needs Fixing
Revision history for this message
Geoff Teale (tealeg) wrote :

All points addressed.

Revision history for this message
Adam Collard (adam-collard) wrote :

Nice, thanks for that. +1

review: Approve
Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: TRIAL_ARGS=-j4 make check
Result: Success
Revno: 926
Branch: lp:~tealeg/landscape-client/notify-on-script-output-truncation
Jenkins: https://ci.lscape.net/job/latch-test-precise/158/

review: Approve (test results)
927. By Geoff Teale

lint

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: