Landscape Client

Merge lp://staging/~tealeg/landscape-client/mocker-replace-test-hasservice into lp://staging/~landscape/landscape-client/trunk

  1. mocker-replace-test-hasservice
  2. Merge into trunk
Proposed by Geoff Teale
Status: Merged
Approved by: Geoff Teale
Approved revision: 869
Merged at revision: 884
Proposed branch: lp://staging/~tealeg/landscape-client/mocker-replace-test-hasservice
Merge into: lp://staging/~landscape/landscape-client/trunk
Diff against target: 234 lines (+62/-61)
2 files modified
landscape/manager/haservice.py (+12/-11)
landscape/manager/tests/test_haservice.py (+50/-50)
To merge this branch: bzr merge lp://staging/~tealeg/landscape-client/mocker-replace-test-hasservice
Reviewer Review Type Date Requested Status
Alberto Donato Approve
🤖 Landscape Builder test results Approve
Chris Glass (community) Approve
Review via email: mp+297576@code.staging.launchpad.net

Commit message

Further mocker to mock replacements.

Testing instructions:

Description of the change

Welcome to hell.

Testing instructions:

To post a comment you must log in.
Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
Chris Glass (tribaal) wrote :

+1 with inline comments

review: Approve
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: TRIAL_ARGS=-j4 make check
Result: Success
Revno: 867
Branch: lp:~tealeg/landscape-client/mocker-replace-test-hasservice
Jenkins: https://ci.lscape.net/job/latch-test/5076/

review: Approve (test results)
lp://staging/~tealeg/landscape-client/mocker-replace-test-hasservice updated
868. By Geoff Teale

Assert call parameters instead of returning them... whoooops

869. By Geoff Teale

lint

Revision history for this message
Geoff Teale (tealeg) wrote :

All Chris' comments addressed.

Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: TRIAL_ARGS=-j4 make check
Result: Success
Revno: 869
Branch: lp:~tealeg/landscape-client/mocker-replace-test-hasservice
Jenkins: https://ci.lscape.net/job/latch-test/5078/

review: Approve (test results)
Revision history for this message
Alberto Donato (ack) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: