Landscape Client

Merge lp://staging/~tealeg/landscape-client/fix-object-has-no-proxy into lp://staging/~landscape/landscape-client/trunk

  1. fix-object-has-no-proxy
  2. Merge into trunk
Proposed by Geoff Teale
Status: Merged
Approved by: Geoff Teale
Approved revision: 469
Merged at revision: 469
Proposed branch: lp://staging/~tealeg/landscape-client/fix-object-has-no-proxy
Merge into: lp://staging/~landscape/landscape-client/trunk
Diff against target: 97 lines (+27/-15)
1 file modified
landscape/ui/model/configuration/tests/test_state.py (+27/-15)
To merge this branch: bzr merge lp://staging/~tealeg/landscape-client/fix-object-has-no-proxy
Reviewer Review Type Date Requested Status
Alberto Donato Approve
Thomas Herve (community) Approve
Review via email: mp+95408@code.staging.launchpad.net

Description of the change

Fixes bug #943622 using the pattern established in previous branches.

The easy way to reproduce the bug is to setup an oneiric chroot using debootstrap and run:

trial landscape.ui.model.configuration.tests.test_state

.. in it!

To post a comment you must log in.
Revision history for this message
Thomas Herve (therve) wrote :

Looks good. Please just remove the commented code.

review: Approve
Revision history for this message
Alberto Donato (ack) wrote :

+1! looks good

#1:
+ print "Skip"

I guess this is a leftover from debug.

review: Approve
Revision history for this message
Geoff Teale (tealeg) wrote :

> Looks good. Please just remove the commented code.

Done, thanks!

lp://staging/~tealeg/landscape-client/fix-object-has-no-proxy updated
471. By Geoff Teale

Removed print statement (from ack's review).

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: