Merge lp://staging/~tealeg/landscape-client/assertIsNone-in-deployment-tests into lp://staging/~landscape/landscape-client/trunk
Proposed by
Geoff Teale
| Status: | Merged |
|---|---|
| Approved by: | Chad Smith |
| Approved revision: | 724 |
| Merged at revision: | 724 |
| Proposed branch: | lp://staging/~tealeg/landscape-client/assertIsNone-in-deployment-tests |
| Merge into: | lp://staging/~landscape/landscape-client/trunk |
| Diff against target: |
12 lines (+1/-1) 1 file modified
landscape/tests/test_deployment.py (+1/-1) |
| To merge this branch: | bzr merge lp://staging/~tealeg/landscape-client/assertIsNone-in-deployment-tests |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Chad Smith | Approve | ||
| David Britton (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Lucid doesn't have assertIsNone. changed to assertEqual
Description of the change
Tests were failing for Lucid as assertIsNone isn't available there.
This branch converts the failing test to use assertEqual.
To post a comment you must log in.
Revision history for this message
| David Britton (dpb) wrote | # |
Revision history for this message
| David Britton (dpb) | # |
review:
Approve
Revision history for this message
| Chad Smith (chad.smith) wrote | # |
Revision history for this message
| 🤖 Landscape Builder (landscape-builder) wrote | # |
Revision history for this message
| Chad Smith (chad.smith) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
LGTM