Charm Helpers

Merge lp://staging/~tealeg/charm-helpers/override-file-name-correction into lp://staging/charm-helpers

override-file-name-correction
Merge into devel

Proposed by Geoff Teale on 2015-08-04

Status:

Merged

Merged at revision:

420

Proposed branch:

lp://staging/~tealeg/charm-helpers/override-file-name-correction

Merge into:

lp://staging/charm-helpers

Diff against target:

43 lines (+4/-4)

2 files modified

charmhelpers/core/host.py (+2/-2)
tests/core/test_host.py (+2/-2)

To merge this branch:

bzr merge lp://staging/~tealeg/charm-helpers/override-file-name-correction

Undecided

Fix Released

Link a bug report

Reviewer	Date Requested	Status
Matt Bruzek	2015-08-04	Approve on 2015-08-04
Cory Johns (community)		Approve on 2015-08-04
Review via email: mp+266897@code.staging.launchpad.net

Description of the change

This branch corrects the name of override files used by core.host.service_pause and core.host.service_resume to match the documented standards.

Revision history for this message

Cory Johns (johnsca) wrote on 2015-08-04:

Matches documentation (http://upstart.ubuntu.com/cookbook/#override-files) and tests pass. +1

review: Approve

Revision history for this message

Matt Bruzek (mbruzek) wrote on 2015-08-04:

I took a look at this change. The tests pass and does match the documentation as Cory already mentioned.

I am not as familiar with this code. Worried about breaking older versions of charmhelpers. Can you explain why someone would call service_pause() and service_resume()? Do you think this of how this would break a charm using this code?

review: Needs Information

Revision history for this message

Geoff Teale (tealeg) wrote on 2015-08-04:

> I took a look at this change. The tests pass and does match the documentation
> as Cory already mentioned.
>
> I am not as familiar with this code. Worried about breaking older versions of
> charmhelpers. Can you explain why someone would call service_pause() and
> service_resume()? Do you think this of how this would break a charm using
> this code?

Hi Matt,

I doubt it will break anything as the functions in question were added by another member of my team for changes he is making in the swift charms - there will be a number of charms that we'll be working on in coming weeks that require those functions. These methods relate to the need to be able to stop services on an individual unit in HA set-up so that some maintenance tasks can be carried out on the machine on which they are running.

Revision history for this message

Matt Bruzek (mbruzek) wrote on 2015-08-04:

Thanks for the response Geoff.

review: Approve