Merge lp://staging/~tdaitx/byobu/lp-1711026-fix-pep8-E722 into lp://staging/byobu

Proposed by Tiago Stürmer Daitx
Status: Merged
Merged at revision: 2561
Proposed branch: lp://staging/~tdaitx/byobu/lp-1711026-fix-pep8-E722
Merge into: lp://staging/byobu
Diff against target: 128 lines (+14/-14)
2 files modified
usr/lib/byobu/include/config.py.in (+10/-10)
usr/lib/byobu/include/select-session.py (+4/-4)
To merge this branch: bzr merge lp://staging/~tdaitx/byobu/lp-1711026-fix-pep8-E722
Reviewer Review Type Date Requested Status
Dustin Kirkland  Pending
Review via email: mp+329168@code.staging.launchpad.net

Description of the change

Byobu currently FTBFS on artful during pep8 verification due to the newly introduced E722 - ie. a 'try:/except:' block with a bare except that should be replaced by a 'try:except Exception:' block.

This patch fixes all bare except: currently in use in byobu.

Log error from build [1]:

# Check python syntax
pep8 --verbose --repeat --ignore W191,E501 usr/lib/byobu/include/config.py usr/lib/byobu/include/select-session.py
checking usr/lib/byobu/include/config.py
usr/lib/byobu/include/config.py:45:1: E722 do not use bare except'
usr/lib/byobu/include/config.py:84:2: E722 do not use bare except'
usr/lib/byobu/include/config.py:99:2: E722 do not use bare except'
usr/lib/byobu/include/config.py:113:3: E722 do not use bare except'
usr/lib/byobu/include/config.py:119:3: E722 do not use bare except'
usr/lib/byobu/include/config.py:176:4: E722 do not use bare except'
usr/lib/byobu/include/config.py:220:4: E722 do not use bare except'
usr/lib/byobu/include/config.py:226:4: E722 do not use bare except'
usr/lib/byobu/include/config.py:344:4: E722 do not use bare except'
usr/lib/byobu/include/config.py:366:2: E722 do not use bare except'
checking usr/lib/byobu/include/select-session.py
usr/lib/byobu/include/select-session.py:30:1: E722 do not use bare except'
usr/lib/byobu/include/select-session.py:159:4: E722 do not use bare except'
usr/lib/byobu/include/select-session.py:166:4: E722 do not use bare except'
usr/lib/byobu/include/select-session.py:177:3: E722 do not use bare except'
debian/rules:6: recipe for target 'override_dh_auto_build' failed
make[1]: *** [override_dh_auto_build] Error 1
make[1]: Leaving directory '/<<PKGBUILDDIR>>'

[1] https://launchpadlibrarian.net/332635385/buildlog_ubuntu-artful-amd64.byobu_5.121-0ubuntu1_BUILDING.txt.gz

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches