Ubuntu Repository Cache Charm

Merge lp://staging/~tcuthbert/ubuntu-repository-cache/squid-mem-qos into lp://staging/ubuntu-repository-cache

  1. squid-mem-qos
  2. Merge into layer-ubuntu-repository-cache
Proposed by Thomas Cuthbert
Status: Rejected
Rejected by: Haw Loeung
Proposed branch: lp://staging/~tcuthbert/ubuntu-repository-cache/squid-mem-qos
Merge into: lp://staging/ubuntu-repository-cache
Diff against target: 227 lines (+148/-1)
5 files modified
config.yaml (+18/-0)
lib/ubuntu_repository_cache/service.py (+1/-0)
lib/ubuntu_repository_cache/squid.py (+69/-1)
lib/ubuntu_repository_cache/util.py (+52/-0)
templates/squid-deb-proxy.service.d/squid-deb-proxy.conf (+8/-0)
To merge this branch: bzr merge lp://staging/~tcuthbert/ubuntu-repository-cache/squid-mem-qos
Reviewer Review Type Date Requested Status
Ubuntu Repository Cache Charmers, Canonical Pending
Review via email: mp+429532@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Haw Loeung (hloeung) wrote :

Comments inline. I tested and confirmed memory limits are applied - https://pastebin.canonical.com/p/3Jh3mSBJfV/

Revision history for this message
Haw Loeung (hloeung) wrote :

FWIW, this supersedes https://code.launchpad.net/~tcuthbert/ubuntu-repository-cache/squid-mem-max/+merge/423754

Revision history for this message
Haw Loeung (hloeung) wrote :

... and superseded yet again - https://code.launchpad.net/~tcuthbert/ubuntu-repository-cache/+git/ubuntu-repository-cache/+merge/429926

Unmerged revisions

374. By Thomas Cuthbert

WIP: squid systemd memory qos

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches