Do Plugins

Merge lp://staging/~taktaktaktaktaktaktaktaktaktak/do-plugins/docklets into lp://staging/do-plugins/docklets

docklets
Merge into docklets

Proposed by Levi Bard on 2010-03-16

Status:	Rejected
Rejected by:	Robert Dyer on 2010-11-04
Proposed branch:	lp://staging/~taktaktaktaktaktaktaktaktaktak/do-plugins/docklets
Merge into:	lp://staging/do-plugins/docklets
Diff against target:	360 lines (+170/-113) 3 files modified GMailDocklet/src/GMailAtom.cs (+168/-111) GMailDocklet/src/GMailDocklet.cs (+1/-1) GMailDocklet/src/GMailMenuButtonArgs.cs (+1/-1)
To merge this branch:	bzr merge lp://staging/~taktaktaktaktaktaktaktaktaktak/do-plugins/docklets
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Robert Dyer (community)		2010-03-16	Disapprove on 2010-03-16
Review via email: mp+21451@code.staging.launchpad.net

Commit message

GMailDocklet: Check for mail in all configured labels.

Description of the change

GMailDocklet: Check for mail in all configured labels.

Revision history for this message

Robert Dyer (psybers) wrote on 2010-03-16:

While we appreciate efforts by community members to give us merges/patches, you are a bit late on this one! Docky (and thus all docklets) have been REMOVED from GNOME Do!

Please take a look at lp:docky instead, and if your patch still seems relevant update it against that codebase (which is different!) and re-submit the merge request.

review: Disapprove

Revision history for this message

Robert Dyer (psybers) wrote on 2010-03-16:

As just a comment, I believe what you are trying to do is already done in the new docklet. In the new docklet, each label gets its own icon and checks every X mins.

Revision history for this message

Levi Bard (taktaktaktaktaktaktaktaktaktak) wrote on 2010-03-16:

Eek, I had no idea that docky was a different project now.
Thanks, I'll take a look.