Merge lp://staging/~taihsiangho/ubiquity/trusty-proposed into lp://staging/~ubuntu-installer/ubiquity/trusty-proposed
Status: | Needs review |
---|---|
Proposed branch: | lp://staging/~taihsiangho/ubiquity/trusty-proposed |
Merge into: | lp://staging/~ubuntu-installer/ubiquity/trusty-proposed |
Diff against target: |
13 lines (+4/-0) 1 file modified
debian/oem-config.oem-config.upstart (+4/-0) |
To merge this branch: | bzr merge lp://staging/~taihsiangho/ubiquity/trusty-proposed |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Mathieu Trudel-Lapierre | Needs Information | ||
Review via email: mp+263496@code.staging.launchpad.net |
Description of the change
(LP:#191417) Add feature to preseed by using boot parameters for stage 3 (OOBE) installation.
.
The current binary package oem-config does not support the feature to preseed by using boot parameters at stage 3, Out-of-box experience, OOBE. By mimicking the implement of casper, getting boot parameters from /proc/cmdline and apply associated preseed files if any, before oem-config-
.
This feature will benefit oem vendors to perform automatic tests for different known end users with different system configuration but the same skeleton oem-installed system. Thus, end users may have better OOBE experience and system updating support.
.
.
Patch regression risk: Low
.
This patch only add one more case option and the feature is isolated to other features.
Unmerged revisions
- 6197. By Taihsiang Ho
-
(LP:#191417) Add feature to preseed by using boot parameters for stage 3 (OOBE) installation.
I'm concerned that this is very different from the way preseeding is normally done for installations or even oem settings -- oem-config itself simply uses whatever "real" debconf keys would be used on the installed system, which means you'd absolutely have to preseed those after the initial install, rather than being able to push everything at once at install time.
In other words; I think rather than having someone touch the installed system and specify extra boot parameters, or even preseed those in a late_command (or even more complicated, boot the installer with them), we should come up with install-time preseedable keys for the questions oem-config will ask.
Simply put; I'd make a copy of timezone, keyboard, etc. under the oem-config namespace, and teach ubiquity/oem-config to read those if we're running in the oem-config case, so that only the questions that are not seeded will be asked, and you can specify all of it at the time you start the installation process. This way, you can simplify things down to a user only having to fill in their name and password.
Additionally, this depends on having a file available on the filesystem already that contains all the necessary parameters; which is unlikely. One way to handle this better would be to allow using a URL like the preseed package does, but that will need changes in ubiquity itself rather than just the upstart job.
Since this particular merge is not incorrect, please provide more information whether this has been considered, and what the exact use case is that you want to fix here.