Merge lp://staging/~system76-dev/ubiquity/trunk into lp://staging/ubiquity

Proposed by Jeremy Soller
Status: Merged
Merged at revision: 6540
Proposed branch: lp://staging/~system76-dev/ubiquity/trunk
Merge into: lp://staging/ubiquity
Diff against target: 419 lines (+103/-110)
7 files modified
d-i/manifest (+5/-3)
debian/changelog (+6/-0)
debian/control (+1/-1)
tests/test_wireless.py (+1/-18)
ubiquity/frontend/gtk_components/nmwidgets.py (+83/-77)
ubiquity/frontend/kde_components/nmwidgets.py (+7/-1)
ubiquity/plugins/ubi-wireless.py (+0/-10)
To merge this branch: bzr merge lp://staging/~system76-dev/ubiquity/trunk
Reviewer Review Type Date Requested Status
Mathieu Trudel-Lapierre Needs Information
Review via email: mp+319142@code.staging.launchpad.net

Description of the change

- Add WPA-2 enterprise support using libnm-gtk
- Remove password box from GTK installer, using libnm-gtk for any secure connections

This patch to `libnm-gtk` must also be applied: https://bugs.launchpad.net/ubuntu/+source/network-manager-applet/+bug/1667129

To post a comment you must log in.
6525. By Jeremy Soller

Switch to using libnma

6526. By Jeremy Soller

Fixes for use of libnma

6527. By Jeremy Soller

Change RemoteConnection to SimpleConnection

Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

Looks fine to me code-wise; now I'll merge and review functionally.

Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

How did you test this? I've built this in my PPA, and installing it on a live session leads to ubiquity not starting the wireless panel at all (I expected it to still show a list of wireless networks).

review: Needs Information
6528. By Jeremy Soller

Merge

6529. By Jeremy Soller

Update changelog

Revision history for this message
Jeremy Soller (jackpot51) wrote :

cyphermox, the wireless network page is skipped if you are connected to a wired network.

6530. By Jeremy Soller

Merge

6531. By Jeremy Soller

Update changelog

6532. By Jeremy Soller

Revert manifest to zesty versions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: