Merge lp://staging/~sylvain-pineau/cdts/fix-1258326 into lp://staging/cdts
Proposed by
Sylvain Pineau
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Zygmunt Krynicki | ||||
| Approved revision: | 2330 | ||||
| Merged at revision: | 2329 | ||||
| Proposed branch: | lp://staging/~sylvain-pineau/cdts/fix-1258326 | ||||
| Merge into: | lp://staging/cdts | ||||
| Diff against target: |
41 lines (+10/-0) 3 files modified
plainbox-gui/canonical-driver-test-suite/qml/ManualInteractionDialog.qml (+3/-0) plainbox-gui/gui-engine/gui-engine.cpp (+5/-0) plainbox-gui/gui-engine/gui-engine.h (+2/-0) |
||||
| To merge this branch: | bzr merge lp://staging/~sylvain-pineau/cdts/fix-1258326 | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Brendan Donegan (community) | Approve | ||
| Zygmunt Krynicki (community) | Approve | ||
| Sylvain Pineau (community) | Needs Resubmitting | ||
|
Review via email:
|
|||
Description of the change
this MR adds a new Qt signal to properly close the Manual Interaction Dialog once a job result is available for a user-interact job.
To post a comment you must log in.
Revision history for this message
| Brendan Donegan (brendan-donegan) wrote | # |
review:
Needs Information
Revision history for this message
| Sylvain Pineau (sylvain-pineau) wrote | # |
review:
Needs Resubmitting
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
I don't particularly see the need for the logging statement. It's harmless of course, but we should be consistent in our use of logging, and at the moment we're not so let's not add any more until we figure out a better logging scheme.