Canonical Driver Test Suite

Merge lp://staging/~sylvain-pineau/cdts/fix-1227684 into lp://staging/cdts

  1. fix-1227684
  2. Merge into trunk
Proposed by Sylvain Pineau
Status: Merged
Approved by: Sylvain Pineau
Approved revision: 2347
Merged at revision: 2346
Proposed branch: lp://staging/~sylvain-pineau/cdts/fix-1227684
Merge into: lp://staging/cdts
Diff against target: 251 lines (+71/-53)
4 files modified
plainbox-gui/canonical-driver-test-suite/qml/ManualInteractionDialog.qml (+4/-25)
plainbox-gui/canonical-driver-test-suite/qml/RunManagerView.qml (+3/-0)
plainbox-gui/gui-engine/gui-engine.cpp (+61/-26)
plainbox-gui/gui-engine/gui-engine.h (+3/-2)
To merge this branch: bzr merge lp://staging/~sylvain-pineau/cdts/fix-1227684
Reviewer Review Type Date Requested Status
Sylvain Pineau (community) Approve
Review via email: mp+202017@code.staging.launchpad.net

Description of the change

Fix for the linked bug to preselect the ui manualdialog outcome with job command results

Requires: https://code.launchpad.net/~sylvain-pineau/checkbox/fix-1227684/+merge/202016

To post a comment you must log in.
lp://staging/~sylvain-pineau/cdts/fix-1227684 updated
2346. By Sylvain Pineau

gui-engine: Properly set the outcome for the ManualInteractionDialog signals

gui-engine now listens to both AskForOutcome and ShowInteractiveUI signals.

2347. By Sylvain Pineau

qml:ManualInteractionDialog: update the (yes/no/skip) with job command result

Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

Self-approved, tested ok with all types of plugins/ all types of error codes.

review: Approve
Revision history for this message
Daniel Manrique (roadmr) wrote :

\o/

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches