OpenERP POS addons

Merge lp://staging/~sylvain-legal/openerp-pos/7.0_pos_second_header into lp://staging/openerp-pos

  1. 7.0_pos_second_header
  2. Merge into 7.0
Proposed by Sylvain LE GAL (GRAP)
Status: Needs review
Proposed branch: lp://staging/~sylvain-legal/openerp-pos/7.0_pos_second_header
Merge into: lp://staging/openerp-pos
Diff against target: 244 lines (+211/-0)
5 files modified
pos_second_header/__init__.py (+21/-0)
pos_second_header/__openerp__.py (+58/-0)
pos_second_header/static/src/css/psh.css (+59/-0)
pos_second_header/static/src/js/psh.js (+47/-0)
pos_second_header/static/src/xml/psh.xml (+26/-0)
To merge this branch: bzr merge lp://staging/~sylvain-legal/openerp-pos/7.0_pos_second_header
Reviewer Review Type Date Requested Status
Pedro Manuel Baeza code review Approve
Cristian Salamea (community) Approve
Review via email: mp+228820@code.staging.launchpad.net

Commit message

[ADD] Add new module to display a second header in Point Of Sale

Description of the change

new module "pos_second_header" that add a second toolbar in the point of sale module (front-end).
This module is useless alone, but some modules depend on it. (pos_restaurant, pos_select_customer, etc.)

Flake8: OK.

Thanks for your reviews.

To post a comment you must log in.
Revision history for this message
Cristian Salamea (ovnicraft) wrote :

I dont know if its necessary license header at XML template.

LGTM

review: Approve
Reply
Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

Hi, Sylvain, thanks for the module. You have to put files inside a directory called 'pos_second_header' or something similar, but the rest LGTM.

review: Needs Fixing (code review)
Reply
Revision history for this message
Sylvain LE GAL (GRAP) (sylvain-legal) wrote :

> Hi, Sylvain, thanks for the module. You have to put files inside a directory
> called 'pos_second_header' or something similar, but the rest LGTM.

Hi thanks for the review. Sorry i'll change that when i'll go back from hollidays.
Regards.

Reply
Revision history for this message
Sylvain LE GAL (GRAP) (sylvain-legal) wrote :

> I dont know if its necessary license header at XML template.
>
> LGTM
Hi. Thanks for the review. My PoV is that code is python file + xml + css + js files. So i put licences in all filds basically.
Regards.

Reply
lp://staging/~sylvain-legal/openerp-pos/7.0_pos_second_header updated
3. By Sylvain LE GAL (GRAP)

[FIX] 'pos_second_header'. Add folder of the module and move files into.

Revision history for this message
Sylvain LE GAL (GRAP) (sylvain-legal) wrote :

Hi Pedro,

I did the change. Are you ok with the new Merge Proposal ?

Regards.

Reply
Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

Yeah, sure!

review: Approve (code review)
Reply
Revision history for this message
Sylvain LE GAL (GRAP) (sylvain-legal) wrote :

Project has moved into github.
https://github.com/odoo-pos/odoo-pos/tree/7.0

review: Disapprove (obsolete)
Reply

Unmerged revisions

3. By Sylvain LE GAL (GRAP)

[FIX] 'pos_second_header'. Add folder of the module and move files into.

2. By Sylvain LE GAL (GRAP)

[REF] Change some descriptions.

1. By Sylvain LE GAL (GRAP)

[ADD] Add new module to display a second header in Point Of Sale

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches