Merge lp://staging/~superscript18/scratch/bugfix-1397186 into lp://staging/~elementary-apps/scratch/scratch

Proposed by SuperScript
Status: Merged
Approved by: Danielle Foré
Approved revision: 1419
Merged at revision: 1431
Proposed branch: lp://staging/~superscript18/scratch/bugfix-1397186
Merge into: lp://staging/~elementary-apps/scratch/scratch
Diff against target: 37 lines (+7/-1)
1 file modified
src/Widgets/DocumentView.vala (+7/-1)
To merge this branch: bzr merge lp://staging/~superscript18/scratch/bugfix-1397186
Reviewer Review Type Date Requested Status
Danielle Foré Approve
Artem Anufrij (community) code style Approve
Review via email: mp+243176@code.staging.launchpad.net

Commit message

Forced the DocumentView to accept drag. Fixes bug #1397186.

Description of the change

Forced the DocumentView to accept drag. Fixes bug #1397186.

To post a comment you must log in.
Revision history for this message
Artem Anufrij (artem-anufrij) wrote :

see comment

review: Needs Fixing (code style)
Revision history for this message
Artem Anufrij (artem-anufrij) wrote :
1419. By SuperScript

Updated to 4x space, code style.

Revision history for this message
SuperScript (superscript18) wrote :

Does that look correct? This is my first work with elementary, so thanks for the tips.

Revision history for this message
Artem Anufrij (artem-anufrij) wrote :

Yeah... That looks good!

Reviewed only code style. UX should be tested by UX-Team.

review: Approve (code style)
Revision history for this message
Danielle Foré (danrabbit) wrote :

Not sure why this needs specific UX review. Looks like a pretty straightforward bug fix to me.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches