Merge lp://staging/~submarine/unity-scope-virtualbox/vboxmanage-parsing into lp://staging/unity-scope-virtualbox

Proposed by David Callé
Status: Merged
Approved by: David Callé
Approved revision: 25
Merged at revision: 25
Proposed branch: lp://staging/~submarine/unity-scope-virtualbox/vboxmanage-parsing
Merge into: lp://staging/unity-scope-virtualbox
Diff against target: 25 lines (+3/-1)
2 files modified
src/unity_virtualbox_daemon.py (+2/-0)
tests/test_virtualbox.py (+1/-1)
To merge this branch: bzr merge lp://staging/~submarine/unity-scope-virtualbox/vboxmanage-parsing
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Paweł Stołowski (community) Approve
Review via email: mp+165037@code.staging.launchpad.net

Commit message

Correctly parse vboxmanage output

Description of the change

This branch fixes vboxmanage output parsing, as the daemon interprets error messages as scope results.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Paweł Stołowski (stolowski) wrote :

LGTM. +1

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: