Unity Firefox Bookmarks Scope

Merge lp://staging/~submarine/unity-scope-firefoxbookmarks/new-icon into lp://staging/unity-scope-firefoxbookmarks

  1. new-icon
  2. Merge into trunk
Proposed by David Callé
Status: Merged
Approved by: David Callé
Approved revision: 29
Merged at revision: 29
Proposed branch: lp://staging/~submarine/unity-scope-firefoxbookmarks/new-icon
Merge into: lp://staging/unity-scope-firefoxbookmarks
Diff against target: 44 lines (+5/-5)
2 files modified
data/firefoxbookmarks.scope.in (+1/-1)
src/unity_firefoxbookmarks_daemon.py (+4/-4)
To merge this branch: bzr merge lp://staging/~submarine/unity-scope-firefoxbookmarks/new-icon
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Paweł Stołowski (community) Approve
Review via email: mp+168081@code.staging.launchpad.net

Commit message

Use the bookmark icon and change Show to Open

Description of the change

Use the bookmarks icon
Change Show to Open (to match other scopes)

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:29
http://jenkins.qa.ubuntu.com/job/unity-scope-firefoxbookmarks-ci/5/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-firefoxbookmarks-saucy-amd64-ci/1
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-firefoxbookmarks-saucy-armhf-ci/1
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-firefoxbookmarks-saucy-i386-ci/1

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-scope-firefoxbookmarks-ci/5/rebuild

review: Approve (continuous-integration)
Revision history for this message
Paweł Stołowski (stolowski) wrote :

31 if not os.path.exists(icon):
32 - icon = 'gtk-about'
33 + icon = None

Why not DEFAULT_RESULT_ICON?

review: Needs Information
Revision history for this message
David Callé (davidc3) wrote :

the do_run method takes care of that later in the process.

Revision history for this message
Paweł Stołowski (stolowski) wrote :

Clarified on IRC. +1.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/unity-scope-firefoxbookmarks-autolanding/4/
Executed test runs:
    SUCCESS: http://s-jenkins:8080/job/generic-cleanup-mbs/206
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-firefoxbookmarks-saucy-amd64-autolanding/1
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-firefoxbookmarks-saucy-armhf-autolanding/1
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-firefoxbookmarks-saucy-i386-autolanding/1

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: