Merge lp://staging/~styluseater/swift/lp610583 into lp://staging/~hudson-openstack/swift/trunk
Proposed by
Adam M Dutko
Status: | Work in progress | ||||
---|---|---|---|---|---|
Proposed branch: | lp://staging/~styluseater/swift/lp610583 | ||||
Merge into: | lp://staging/~hudson-openstack/swift/trunk | ||||
Diff against target: |
159 lines (+36/-29) 3 files modified
bin/swift-account-audit (+18/-13) bin/swift-account-replicator (+9/-8) bin/swift-container-replicator (+9/-8) |
||||
To merge this branch: | bzr merge lp://staging/~styluseater/swift/lp610583 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Chuck Thier (community) | Needs Fixing | ||
Review via email:
|
Description of the change
Found three files using getopt:
bin/swift-
bin/swift-
bin/swift-
I removed the getopt import and replaced it with optparse (OptionParser). I also replaced the usage of options values passed on the command line instead of using the arg array. I tested the -h and --help options worked but don't have a full swift environment so I've not "tested" the true functionality.
To post a comment you must log in.
Unmerged revisions
- 45. By Adam M Dutko
-
Fix -f option and use first arg for config.
- 44. By Adam M Dutko
-
Changed getopt to optparse for three scripts.
Hi Adam,
There are a couple of things that should be changed so that we don't change the options for the commans:
For bin/swift- account- audit:
The original version used a -e to set the error file, but your version uses -f
for bin/swift- account- replicator and bin/swift- container- replicator:
The original version used the first argument as the path to the config not -c
Please make the above changes, and resubmit the proposal.
Thanks!