Systers-mailman

Merge lp://staging/~stylistica/systers/adminUI into lp://staging/~systers-dev/systers/development

  1. adminUI
  2. Merge into development
Proposed by Sneha Priscilla
Status: Merged
Merged at revision: 83
Proposed branch: lp://staging/~stylistica/systers/adminUI
Merge into: lp://staging/~systers-dev/systers/development
Diff against target: 506 lines (+501/-0)
1 file modified
Mailman/Gui/General.py (+501/-0)
To merge this branch: bzr merge lp://staging/~stylistica/systers/adminUI
Reviewer Review Type Date Requested Status
Nicki Hutchens (community) Approve
Anna SdG Approve
Robin J Pending
Review via email: mp+114890@code.staging.launchpad.net

This proposal supersedes a proposal from 2012-07-04.

Description of the change

Added admin UI for essays, essay questions and full name .

Made changes to one file from Mailman : ../Mailman/Gui/General.py and added it.
 Changed lines 383-401

To post a comment you must log in.
Revision history for this message
Robin J (robin-jeffries) wrote : Posted in a previous version of this proposal

Looks good

review: Approve
Revision history for this message
Anna SdG (anna-granudd) wrote : Posted in a previous version of this proposal

I agree with Robin but maybe you could add a "." at the end of each sentence of the description text (to match the other fields on the page)? Sorry for being picky... Thanks.

Revision history for this message
Sneha Priscilla (stylistica) wrote : Posted in a previous version of this proposal

That's alright :) I had totally missed that !

On Fri, Jul 6, 2012 at 12:40 AM, Anna SdG <email address hidden> wrote:
> I agree with Robin but maybe you could add a "." at the end of each sentence of the description text (to match the other fields on the page)? Sorry for being picky... Thanks.
> --
> https://code.launchpad.net/~stylistica/systers/adminUI/+merge/113416
> You are the owner of lp:~stylistica/systers/adminUI.

Revision history for this message
Anna SdG (anna-granudd) wrote :

Thanks for adding the dots. :)

review: Approve
Revision history for this message
Nicki Hutchens (nhutchen) wrote :

Thanks for explaining the changes. It looks good.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches