Postorius

Merge lp://staging/~stylistica/postorius/user_preferences into lp://staging/postorius

user_preferences
Merge into trunk

Proposed by Sneha Priscilla on 2013-08-08

Status:	Merged
Merged at revision:	150
Proposed branch:	lp://staging/~stylistica/postorius/user_preferences
Merge into:	lp://staging/postorius
Diff against target:	239 lines (+73/-98) 3 files modified src/postorius/forms.py (+11/-17) src/postorius/templates/postorius/user_mailmansettings.html (+44/-78) src/postorius/views/user.py (+18/-3)
To merge this branch:	bzr merge lp://staging/~stylistica/postorius/user_preferences
Related bugs:	Link a bug report

Reviewer	Date Requested	Status
Terri		Approve on 2013-10-05
Florian Fuchs	2013-08-08	Pending
Review via email: mp+179274@code.staging.launchpad.net

Description of the change

I've added a form for the user to view/update their mailing list preferences on a global level.

For these changes to work, the following branches need to be merged into Mailman and Mailman.client respectively:

https://code.launchpad.net/~stylistica/mailman/user_preferences
https://code.launchpad.net/~stylistica/mailman.client/user_preferences

Revision history for this message

Florian Fuchs (flo-fuchs) wrote on 2013-09-01:

Hi Sneha,

thanks for the merge request!

The new form, as well as the template and view code look pretty good!

The only thing left to do in my view is some style-related cleanup. So if you want to make it perfect I'd check for PEP8 inconsistencies (long lines, missing/unnecessary spaces etc.). Also, there seem to be some lines containing tabs instead of spaces.

Other than that the changes are good!
Thanks again.

Florian

Revision history for this message

Terri (terriko) wrote on 2013-10-05:

We're looking for some "easy" bugs to fix at the GHC Open Source Day, so I'm actually going to merge this as-is and then let our new contributors find the style problems as simple first commits. (I know, I know, this isn't how it's supposed to be done, but it'll be fun!)

review: Approve