Merge lp://staging/~stylistica/mailman/user_preferences into lp://staging/mailman
Proposed by
Sneha Priscilla
| Status: | Merged |
|---|---|
| Approved by: | Barry Warsaw |
| Approved revision: | 7216 |
| Merged at revision: | 7220 |
| Proposed branch: | lp://staging/~stylistica/mailman/user_preferences |
| Merge into: | lp://staging/mailman |
| Diff against target: |
11 lines (+1/-0) 1 file modified
src/mailman/rest/preferences.py (+1/-0) |
| To merge this branch: | bzr merge lp://staging/~stylistica/mailman/user_preferences |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Barry Warsaw | Approve | ||
| Florian Fuchs | Pending | ||
|
Review via email:
|
|||
Description of the change
A small fix to add a missing hide_address reference. Required for Postorius user preferences.
Should I submit this as a patch?
To post a comment you must log in.
Revision history for this message
| Barry Warsaw (barry) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Hi! Thanks for this branch. Now that I have the test suite working again, I can merge this in.
I'm going to accept this branch, but let me just mention a few things that may make future branches easier to review.
* Please use only spaces for indentation, never tabs. Be sure your editor never uses tabs for Mailman code specifically, and (IMHO) Python code in general.
* There were no tests, but an existing test failed. In this case, it would be fine if the existing test were fixed. Please learn how to run the test suite and watch out for test failures. If you feel like you need help with adding tests, please let us know on the mailing list!
I've fixed the tabs and tests... thanks!