Merge lp://staging/~stylesen/lava-scheduler/fix-worker-multinode-error into lp://staging/lava-scheduler
Proposed by
Senthil Kumaran S
| Status: | Superseded |
|---|---|
| Proposed branch: | lp://staging/~stylesen/lava-scheduler/fix-worker-multinode-error |
| Merge into: | lp://staging/lava-scheduler |
| Diff against target: |
32 lines (+10/-4) 1 file modified
lava_scheduler_daemon/service.py (+10/-4) |
| To merge this branch: | bzr merge lp://staging/~stylesen/lava-scheduler/fix-worker-multinode-error |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Antonio Terceiro | Needs Fixing | ||
|
Review via email:
|
|||
This proposal has been superseded by a proposal from 2013-08-31.
Description of the change
Fix scheduling jobs across multiple workers setup.
To post a comment you must log in.
Unmerged revisions
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
> === modified file 'lava_scheduler
> --- lava_scheduler_
> +++ lava_scheduler_
> @@ -192,7 +192,6 @@
> if d.hostname in configured_boards:
> if job:
> job = self._fix_device(d, job)
> - if job:
> job_list.add(job)
This conditional has to stay because _fix_device (which should be called
_allocate_device instead BTW) might return None, in the case where multiple
schedulers try to allocate the same job to different boards, but the local
scheduler lost the race.
Otherwise +1
review needs-fixing