Merge into trunk : testdef-from-repo : Code : LAVA Dispatcher

Status:	Merged
Approved by:	Michael Hudson-Doyle on 2012-11-20
Approved revision:	450
Merged at revision:	460
Proposed branch:	lp://staging/~stylesen/lava-dispatcher/testdef-from-repo
Merge into:	lp://staging/lava-dispatcher
Diff against target:	191 lines (+115/-19) 1 file modified lava_dispatcher/actions/lava_test_shell.py (+115/-19)
To merge this branch:	bzr merge lp://staging/~stylesen/lava-dispatcher/testdef-from-repo
Related bugs:	Link a bug report
Related blueprints:	Test Case Management Core (Essential)

Reviewer	Review Type	Date Requested	Status
Michael Hudson-Doyle (community)		2012-11-19	Approve on 2012-11-20
Review via email: mp+134835@code.staging.launchpad.net

Revision history for this message

Michael Hudson-Doyle (mwhudson) wrote on 2012-11-19:

#

Senthil Kumaran S <email address hidden> writes:

> Senthil Kumaran S has proposed merging lp:~stylesen/lava-dispatcher/testdef-from-repo into lp:lava-dispatcher.
>
> Requested reviews:
> Linaro Validation Team (linaro-validation)
>
> For more details, see:
> https://code.launchpad.net/~stylesen/lava-dispatcher/testdef-from-repo/+merge/134835
>
> This branch implements the following features:
>
> 1) Adds ability to pull a bzr/git repo that includes the test def.
> 2) Adds ability to pull a specific revision of the repo.
>
> --
> https://code.launchpad.net/~stylesen/lava-dispatcher/testdef-from-repo/+merge/134835
> You are subscribed to branch lp:lava-dispatcher.

Hi Senthil,

This branch looks really pretty great (I have a test branch based on
this and some other branches that I'm going to be trying to implement
audio capture with it today). Thanks so much for taking Andy's and my
suggestions on board. I have a few suggestions/quibbles, but I think
this will be ready for landing very soon.

> === modified file 'lava_dispatcher/actions/lava_test_shell.py'
> --- lava_dispatcher/actions/lava_test_shell.py 2012-11-08 14:08:30 +0000
> +++ lava_dispatcher/actions/lava_test_shell.py 2012-11-19 06:43:11 +0000
> @@ -22,6 +22,8 @@
>
> import json
> import yaml
> +import glob
> +import time
> import logging
> import os
> import pexpect
> @@ -100,17 +102,20 @@
> parameters_schema = {
> 'type': 'object',
> 'properties': {
> - 'testdef_urls': {'type': 'array', 'items': {'type': 'string'}},
> + 'testdef_urls': {'type': 'array', 'items': {'type': 'string'},
> + 'optional': True},
> + 'testdef_repos': {'type': 'array', 'items': {'type': 'object'},
> + 'optional': True},

I think it's possible to be more specific here isn't it? You could
specify the properties the objects in the testdef_repos array is allowed
to have. But maybe let's not worry about this for now.

> 'timeout': {'type': 'integer', 'optional': True},
> },
> 'additionalProperties': False,
> }
>
> - def run(self, testdef_urls, timeout=-1):
> + def run(self, testdef_urls=None, testdef_repos=None, timeout=-1):
> target = self.client.target_device
> self._assert_target(target)
>
> - self._configure_target(target, testdef_urls)
> + self._configure_target(target, testdef_urls, testdef_repos)
>
> with target.runner() as runner:
> patterns = [
> @@ -128,11 +133,86 @@
>
> self._bundle_results(target)
>
> - def _get_test_definition(self, testdef_url, tmpdir):
> - testdef_file = download_image(testdef_url, self.context, tmpdir)
> - with open(testdef_file, 'r') as f:
> - logging.info('loading test definition')
> - return yaml.load(f)
> + def _get_test_definition_from_url(self, d, ldir, testdef_urls, tmpdir):
> + tdirs = []
> + for url in testdef_urls:
> + testdef_file = download_image(url, self.context, tmpdir)
> + with open(testdef_file, 'r') as f:
> + logging.info(...

Senthil Kumaran S <senthil.kumaran@linaro.org> writes:

> Senthil Kumaran S has proposed merging lp:~stylesen/lava-dispatcher/testdef-from-repo into lp:lava-dispatcher.
>
> Requested reviews:
>   Linaro Validation Team (linaro-validation)
>
> For more details, see:
> https://code.launchpad.net/~stylesen/lava-dispatcher/testdef-from-repo/+merge/134835
>
> This branch implements the following features:
>
> 1) Adds ability to pull a bzr/git repo that includes the test def.
> 2) Adds ability to pull a specific revision of the repo.
>
> -- 
> https://code.launchpad.net/~stylesen/lava-dispatcher/testdef-from-repo/+merge/134835
> You are subscribed to branch lp:lava-dispatcher.

Hi Senthil,

This branch looks really pretty great (I have a test branch based on
this and some other branches that I'm going to be trying to implement
audio capture with it today).  Thanks so much for taking Andy's and my
suggestions on board. I have a few suggestions/quibbles, but I think
this will be ready for landing very soon.

> === modified file 'lava_dispatcher/actions/lava_test_shell.py'
> --- lava_dispatcher/actions/lava_test_shell.py	2012-11-08 14:08:30 +0000
> +++ lava_dispatcher/actions/lava_test_shell.py	2012-11-19 06:43:11 +0000
> @@ -22,6 +22,8 @@
>  
>  import json
>  import yaml
> +import glob
> +import time
>  import logging
>  import os
>  import pexpect
> @@ -100,17 +102,20 @@
>      parameters_schema = {
>          'type': 'object',
>          'properties': {
> -            'testdef_urls': {'type': 'array', 'items': {'type': 'string'}},
> +            'testdef_urls': {'type': 'array', 'items': {'type': 'string'},
> +                             'optional': True},
> +            'testdef_repos': {'type': 'array', 'items': {'type': 'object'},
> +                              'optional': True},

I think it's possible to be more specific here isn't it?  You could
specify the properties the objects in the testdef_repos array is allowed
to have.  But maybe let's not worry about this for now.

>              'timeout': {'type': 'integer', 'optional': True},
>              },
>          'additionalProperties': False,
>          }
>  
> -    def run(self, testdef_urls, timeout=-1):
> +    def run(self, testdef_urls=None, testdef_repos=None, timeout=-1):
>          target = self.client.target_device
>          self._assert_target(target)
>  
> -        self._configure_target(target, testdef_urls)
> +        self._configure_target(target, testdef_urls, testdef_repos)
>  
>          with target.runner() as runner:
>              patterns = [
> @@ -128,11 +133,86 @@
>  
>          self._bundle_results(target)
>  
> -    def _get_test_definition(self, testdef_url, tmpdir):
> -        testdef_file = download_image(testdef_url, self.context, tmpdir)
> -        with open(testdef_file, 'r') as f:
> -            logging.info('loading test definition')
> -            return yaml.load(f)
> +    def _get_test_definition_from_url(self, d, ldir, testdef_urls, tmpdir):
> +        tdirs = []
> +        for url in testdef_urls:
> +            testdef_file = download_image(url, self.context, tmpdir)
> +            with open(testdef_file, 'r') as f:
> +                logging.info('loading test definition')
> +                testdef = yaml.load(f)
> +
> +                # android mount the partition under /system, while ubuntu
> +                # mounts under /, so we have hdir for where it is on the
> +                # host and tdir for how the target will see the path
> +                timestamp = str(time.time())
> +                hdir = '%s/tests/%s_%s' % \
> +                    (d, timestamp, testdef['metadata']['name'])
> +                tdir = '%s/tests/%s_%s' % \
> +                    (ldir, timestamp, testdef['metadata']['name'])
> +                self._copy_test(hdir, tdir, testdef)
> +                tdirs.append(tdir)

I think now that the version of this code in
_get_test_definition_from_url and _get_test_definition_from_repo are so
similar, it would be better to move this loop out to the call site
again.  _get_test_definition_from_* could return a list [(testdef,
repo)] where repo would be None for the url case.

> +        return tdirs
> +
> +    def _get_testdef_git_repo(self, testdef_repo, tmpdir, revision):
> +        cwd = os.getcwd()
> +        gitdir = os.path.join(tmpdir, 'gittestrepo')
> +        try:
> +            status = subprocess.call(['git', 'clone', testdef_repo,
> +                                      gitdir])

It's at the level of personal preference, but I prefer to wrap long
argument lists like this:

function_name(
     long, list, of, arguments)

or this:

function_name(
     long,
     list,
     of,
     arguments)

And I think most of the LAVA codebase follows this style.

> +            if revision:
> +                os.chdir(gitdir)
> +                status = subprocess.call(['git', 'checkout', revision])
> +            return gitdir
> +        except Exception as e:
> +            logging.error('Unable to get test definition from git\n' + str(e))
> +        finally:
> +            os.chdir(cwd)
> +
> +    def _get_testdef_bzr_repo(self, testdef_repo, tmpdir, revision):
> +        bzrdir = os.path.join(tmpdir, 'bzrtestrepo')
> +        try:
> +            # As per bzr revisionspec, '-1' is "The last revision in a
> +            # branch".
> +            if revision is None:
> +                revision = '-1'
> +
> +            status = subprocess.call(['bzr', 'branch', '-r', revision,
> +                                      testdef_repo, bzrdir])
> +            return bzrdir
> +        except Exception as e:
> +            logging.error('Unable to get test definition from bzr\n' + str(e))
> +
> +    def _get_test_definition_from_repo(self, d, ldir, testdef_repo, tmpdir):
> +        tdirs = []
> +        if 'git-repo' in testdef_repo:
> +            repo = self._get_testdef_git_repo(testdef_repo['git-repo'],
> +                                              tmpdir,
> +                                              testdef_repo.get('revision'))
> +
> +        if 'bzr-repo' in testdef_repo:
> +            repo = self._get_testdef_bzr_repo(testdef_repo['bzr-repo'],
> +                                              tmpdir,
> +                                              testdef_repo.get('revision'))
> +
> +        for test in testdef_repo['testdefs']:
> +            with open(os.path.join(repo, test), 'r') as f:
> +                logging.info('loading test definition ...')
> +                testdef = yaml.load(f)
> +
> +            # android mount the partition under /system, while ubuntu mounts
> +            # under /, so we have hdir for where it is on the host and tdir
> +            # for how the target will see the path
> +            timestamp = str(time.time())
> +            hdir = '%s/tests/%s_%s' % \
> +                (d, timestamp, testdef['metadata']['name'])
> +            tdir = '%s/tests/%s_%s' % \
> +                (ldir, timestamp, testdef['metadata']['name'])
> +
> +            self._copy_test(hdir, tdir, testdef, repo)
> +            tdirs.append(tdir)

This is the other copy of the code I was complaining about :-)

> +        return tdirs
>  
>      def _copy_runner(self, mntdir, target):
>          runner = target.deployment_data['lava_test_runner']
> @@ -215,7 +295,7 @@
>                  for cmd in testdef['install']['steps']:
>                      f.write('%s\n' % cmd)
>  
> -    def _copy_test(self, hostdir, targetdir, testdef):
> +    def _copy_test(self, hostdir, targetdir, testdef, testdef_repo=None):
>          self._sw_sources = []
>          utils.ensure_directory(hostdir)
>          with open('%s/testdef.yaml' % hostdir, 'w') as f:
> @@ -233,11 +313,16 @@
>                  for cmd in testdef['run']['steps']:
>                      f.write('%s\n' % cmd)
>  
> +        if testdef_repo:
> +            for filepath in glob.glob(os.path.join(testdef_repo, '*')):
> +                shutil.copy2(filepath, hostdir)
> +            logging.info('copied all test files')
> +
>      def _mk_runner_dirs(self, mntdir):
>          utils.ensure_directory('%s/bin' % mntdir)
>          utils.ensure_directory_empty('%s/tests' % mntdir)
>  
> -    def _configure_target(self, target, testdef_urls):
> +    def _configure_target(self, target, testdef_urls, testdef_repos):
>          ldir = target.deployment_data['lava_test_dir']
>  
>          results_part = target.deployment_data['lava_test_results_part_attr']
> @@ -247,15 +332,17 @@
>              self._mk_runner_dirs(d)
>              self._copy_runner(d, target)
>              testdirs = []
> -            for i, url in enumerate(testdef_urls):
> -                testdef = self._get_test_definition(url, target.scratch_dir)
> -                # android mount the partition under /system, while ubuntu
> -                # mounts under /, so we have hdir for where it is on the host
> -                # and tdir for how the target will see the path
> -                hdir = '%s/tests/%d_%s' % (d, i, testdef.get('metadata').get('name'))
> -                tdir = '%s/tests/%d_%s' % (ldir, i, testdef.get('metadata').get('name'))
> -                self._copy_test(hdir, tdir, testdef)
> -                testdirs.append(tdir)
> +
> +            if testdef_urls:
> +                tdirs = self._get_test_definition_from_url( \
> +                    d, ldir, testdef_urls, target.scratch_dir)
> +                testdirs = testdirs + tdirs
> +
> +            if testdef_repos:
> +                for repo in testdef_repos:
> +                    tdirs = self._get_test_definition_from_repo( \
> +                        d, ldir, repo, target.scratch_dir)
> +                    testdirs = testdirs + tdirs
>  
>              with open('%s/lava-test-runner.conf' % d, 'w') as f:
>                  for testdir in testdirs:

Cheers,
mwh

Revision history for this message

Michael Hudson-Doyle (mwhudson) wrote on 2012-11-19:

#

Michael Hudson-Doyle <email address hidden> writes:

>> + return tdirs
>> +
>> + def _get_testdef_git_repo(self, testdef_repo, tmpdir, revision):
>> + cwd = os.getcwd()
>> + gitdir = os.path.join(tmpdir, 'gittestrepo')
>> + try:
>> + status = subprocess.call(['git', 'clone', testdef_repo,
>> + gitdir])

Oh, I forgot a point. You don't seem to examine status here -- perhaps
calling check_call instead is what you want?

Cheers,
mwh

Revision history for this message

Senthil Kumaran S (stylesen) wrote on 2012-11-20:

#

Hi Mike,

On Tuesday 20 November 2012 03:06 AM, Michael Hudson-Doyle wrote:
> This branch looks really pretty great (I have a test branch based on
> this and some other branches that I'm going to be trying to implement
> audio capture with it today). Thanks so much for taking Andy's and my
> suggestions on board. I have a few suggestions/quibbles, but I think
> this will be ready for landing very soon.

Thanks for your detailed review. I shall make the necessary changes as
per your review comments and then push the code today.

Thank You.
--
Senthil Kumaran S
http://www.stylesen.org/
http://www.sasenthilkumaran.com/

lp://staging/~stylesen/lava-dispatcher/testdef-from-repo updated on 2012-11-20

450. By Senthil Kumaran S on 2012-11-20

Code change as per review comments from mwhudson. Following are notable ones:

1) Define the parameter schema for job which specifies the test definitions.
2) Refactor _get_test_definition_from_*, which now got merged into
_get_test_definition
3) Use subprocess.check_call instead of subprocess.call
4) Fix some indentation.

Revision history for this message

Senthil Kumaran S (stylesen) wrote on 2012-11-20:

#

Download full text (4.4 KiB)

Hi Michael,

At revision 450 in branch lp:~stylesen/lava-dispatcher/testdef-from-repo
I fixed all the things which you have pointed out.

On Tuesday 20 November 2012 03:06 AM, Michael Hudson-Doyle wrote:
>> === modified file 'lava_dispatcher/actions/lava_test_shell.py'
>> --- lava_dispatcher/actions/lava_test_shell.py 2012-11-08 14:08:30 +0000
>> +++ lava_dispatcher/actions/lava_test_shell.py 2012-11-19 06:43:11 +0000
>> @@ -22,6 +22,8 @@
>>
>> import json
>> import yaml
>> +import glob
>> +import time
>> import logging
>> import os
>> import pexpect
>> @@ -100,17 +102,20 @@
>> parameters_schema = {
>> 'type': 'object',
>> 'properties': {
>> - 'testdef_urls': {'type': 'array', 'items': {'type': 'string'}},
>> + 'testdef_urls': {'type': 'array', 'items': {'type': 'string'},
>> + 'optional': True},
>> + 'testdef_repos': {'type': 'array', 'items': {'type': 'object'},
>> + 'optional': True},
>
> I think it's possible to be more specific here isn't it? You could
> specify the properties the objects in the testdef_repos array is allowed
> to have. But maybe let's not worry about this for now.

Modified the parameter_schema to be more specific.

>> 'timeout': {'type': 'integer', 'optional': True},
>> },
>> 'additionalProperties': False,
>> }
>>
>> - def run(self, testdef_urls, timeout=-1):
>> + def run(self, testdef_urls=None, testdef_repos=None, timeout=-1):
>> target = self.client.target_device
>> self._assert_target(target)
>>
>> - self._configure_target(target, testdef_urls)
>> + self._configure_target(target, testdef_urls, testdef_repos)
>>
>> with target.runner() as runner:
>> patterns = [
>> @@ -128,11 +133,86 @@
>>
>> self._bundle_results(target)
>>
>> - def _get_test_definition(self, testdef_url, tmpdir):
>> - testdef_file = download_image(testdef_url, self.context, tmpdir)
>> - with open(testdef_file, 'r') as f:
>> - logging.info('loading test definition')
>> - return yaml.load(f)
>> + def _get_test_definition_from_url(self, d, ldir, testdef_urls, tmpdir):
>> + tdirs = []
>> + for url in testdef_urls:
>> + testdef_file = download_image(url, self.context, tmpdir)
>> + with open(testdef_file, 'r') as f:
>> + logging.info('loading test definition')
>> + testdef = yaml.load(f)
>> +
>> + # android mount the partition under /system, while ubuntu
>> + # mounts under /, so we have hdir for where it is on the
>> + # host and tdir for how the target will see the path
>> + timestamp = str(time.time())
>> + hdir = '%s/tests/%s_%s' % \
>> + (d, timestamp, testdef['metadata']['name'])
>> + tdir = '%s/tests/%s_%s' % \
>> + (ldir, timestamp, testdef['metadata']['name'])
>> + self._copy_test(hdir, tdir, testdef)
>> + tdirs.append(tdir)
>
> I think n...

Hi Michael,

At revision 450 in branch lp:~stylesen/lava-dispatcher/testdef-from-repo 
I fixed all the things which you have pointed out.

On Tuesday 20 November 2012 03:06 AM, Michael Hudson-Doyle wrote:
>> === modified file 'lava_dispatcher/actions/lava_test_shell.py'
>> --- lava_dispatcher/actions/lava_test_shell.py	2012-11-08 14:08:30 +0000
>> +++ lava_dispatcher/actions/lava_test_shell.py	2012-11-19 06:43:11 +0000
>> @@ -22,6 +22,8 @@
>>
>>   import json
>>   import yaml
>> +import glob
>> +import time
>>   import logging
>>   import os
>>   import pexpect
>> @@ -100,17 +102,20 @@
>>       parameters_schema = {
>>           'type': 'object',
>>           'properties': {
>> -            'testdef_urls': {'type': 'array', 'items': {'type': 'string'}},
>> +            'testdef_urls': {'type': 'array', 'items': {'type': 'string'},
>> +                             'optional': True},
>> +            'testdef_repos': {'type': 'array', 'items': {'type': 'object'},
>> +                              'optional': True},
>
> I think it's possible to be more specific here isn't it?  You could
> specify the properties the objects in the testdef_repos array is allowed
> to have.  But maybe let's not worry about this for now.

Modified the parameter_schema to be more specific.

>>               'timeout': {'type': 'integer', 'optional': True},
>>               },
>>           'additionalProperties': False,
>>           }
>>
>> -    def run(self, testdef_urls, timeout=-1):
>> +    def run(self, testdef_urls=None, testdef_repos=None, timeout=-1):
>>           target = self.client.target_device
>>           self._assert_target(target)
>>
>> -        self._configure_target(target, testdef_urls)
>> +        self._configure_target(target, testdef_urls, testdef_repos)
>>
>>           with target.runner() as runner:
>>               patterns = [
>> @@ -128,11 +133,86 @@
>>
>>           self._bundle_results(target)
>>
>> -    def _get_test_definition(self, testdef_url, tmpdir):
>> -        testdef_file = download_image(testdef_url, self.context, tmpdir)
>> -        with open(testdef_file, 'r') as f:
>> -            logging.info('loading test definition')
>> -            return yaml.load(f)
>> +    def _get_test_definition_from_url(self, d, ldir, testdef_urls, tmpdir):
>> +        tdirs = []
>> +        for url in testdef_urls:
>> +            testdef_file = download_image(url, self.context, tmpdir)
>> +            with open(testdef_file, 'r') as f:
>> +                logging.info('loading test definition')
>> +                testdef = yaml.load(f)
>> +
>> +                # android mount the partition under /system, while ubuntu
>> +                # mounts under /, so we have hdir for where it is on the
>> +                # host and tdir for how the target will see the path
>> +                timestamp = str(time.time())
>> +                hdir = '%s/tests/%s_%s' % \
>> +                    (d, timestamp, testdef['metadata']['name'])
>> +                tdir = '%s/tests/%s_%s' % \
>> +                    (ldir, timestamp, testdef['metadata']['name'])
>> +                self._copy_test(hdir, tdir, testdef)
>> +                tdirs.append(tdir)
>
> I think now that the version of this code in
> _get_test_definition_from_url and _get_test_definition_from_repo are so
> similar, it would be better to move this loop out to the call site
> again.  _get_test_definition_from_* could return a list [(testdef,
> repo)] where repo would be None for the url case.

Re-factored the code and merged _get_test_definition_from_* into a 
single function ie., _get_test_definition

>> +        return tdirs
>> +
>> +    def _get_testdef_git_repo(self, testdef_repo, tmpdir, revision):
>> +        cwd = os.getcwd()
>> +        gitdir = os.path.join(tmpdir, 'gittestrepo')
>> +        try:
>> +            status = subprocess.call(['git', 'clone', testdef_repo,
>> +                                      gitdir])
>
> It's at the level of personal preference, but I prefer to wrap long
> argument lists like this:
>
>    function_name(
>       long, list, of, arguments)
>
> or this:
>
>    function_name(
>       long,
>       list,
>       of,
>       arguments)
>
> And I think most of the LAVA codebase follows this style.

Changed to above style wherever I changed the code inside the file.

I request you to review the changes and let me know if it looks good for 
a merge :)

Thank You.
-- 
Senthil Kumaran S
http://www.stylesen.org/
http://www.sasenthilkumaran.com/

Revision history for this message

Senthil Kumaran S (stylesen) wrote on 2012-11-20:

#

Hi Michael,

On Tuesday 20 November 2012 04:16 AM, Michael Hudson-Doyle wrote:
> Michael Hudson-Doyle <email address hidden> writes:
>
>>> + return tdirs
>>> +
>>> + def _get_testdef_git_repo(self, testdef_repo, tmpdir, revision):
>>> + cwd = os.getcwd()
>>> + gitdir = os.path.join(tmpdir, 'gittestrepo')
>>> + try:
>>> + status = subprocess.call(['git', 'clone', testdef_repo,
>>> + gitdir])
>
> Oh, I forgot a point. You don't seem to examine status here -- perhaps
> calling check_call instead is what you want?

Changed the above to check_call @ revision 450.

Thank You.
--
Senthil Kumaran S
http://www.stylesen.org/
http://www.sasenthilkumaran.com/

Revision history for this message

Michael Hudson-Doyle (mwhudson) wrote on 2012-11-20:

#

Nice work, please merge.

review: Approve

Revision history for this message

Senthil Kumaran S (stylesen) wrote on 2012-11-21:

#

Hi Michael,

On Wednesday 21 November 2012 02:35 AM, Michael Hudson-Doyle wrote:
> The proposal to merge lp:~stylesen/lava-dispatcher/testdef-from-repo into lp:lava-dispatcher has been updated.
>
> Status: Needs review => Approved

I spent time on merging this branch to trunk today. But due to new
changes in trunk I could not make the merge. My json job files and
testdef.yaml which used to work started giving the following error in
dashboard:

"Unrecognized or missing document format"

I am unsure what should be changed in order to get over this :( Need
your help here to merge my branch to trunk.

Thank You.
--
Senthil Kumaran S
http://www.stylesen.org/
http://www.sasenthilkumaran.com/

Revision history for this message

Senthil Kumaran S (stylesen) wrote on 2012-11-21:

#

On Wednesday 21 November 2012 05:19 PM, Senthil Kumaran S wrote:
> On Wednesday 21 November 2012 02:35 AM, Michael Hudson-Doyle wrote:
>> The proposal to merge lp:~stylesen/lava-dispatcher/testdef-from-repo into lp:lava-dispatcher has been updated.
>>
>> Status: Needs review => Approved
>
> I spent time on merging this branch to trunk today. But due to new
> changes in trunk I could not make the merge. My json job files and
> testdef.yaml which used to work started giving the following error in
> dashboard:
>
> "Unrecognized or missing document format"
>
> I am unsure what should be changed in order to get over this :( Need
> your help here to merge my branch to trunk.

Nevermind, I managed to get past this by upgrading my instance to the
latest versions available and my branch seems to work!!! Will merge it
shortly.

Thank You.
--
Senthil Kumaran S
http://www.stylesen.org/
http://www.sasenthilkumaran.com/

LAVA Dispatcher

Merge lp://staging/~stylesen/lava-dispatcher/testdef-from-repo into lp://staging/lava-dispatcher

Commit message

Description of the change

Preview Diff

Subscribers