Merge lp://staging/~stylesen/lava-dispatcher/add-on-to-testdef-yaml into lp://staging/lava-dispatcher

looks pretty good to me. one thing its probably worth adding now is either a docs entry detailing these YAML fields or an annotated example

On Thursday 24 January 2013 12:14 AM, Andy Doan wrote:
> looks pretty good to me. one thing its probably worth adding now is either a docs entry detailing these YAML fields or an annotated example

Yep, I shall do that shortly (its in my TODO already).

Thank You.
--
Senthil Kumaran S
http://www.stylesen.org/
http://www.sasenthilkumaran.com/

Senthil Kumaran S <email address hidden> writes:

> +def _get_testdef_info(testdef):
> + metadata = {}
> + metadata['version'] = testdef['metadata']['version']
> + metadata['description'] = testdef['metadata']['description']
> + metadata['format'] = testdef['metadata']['format']
> + metadata['os'] = ','.join(testdef['metadata']['os'])
> + metadata['devices'] = ','.join(testdef['metadata']['devices'])
> + metadata['environment'] = ','.join(testdef['metadata']['environment'])
> + return metadata

I don't think it's reasonable to assume that the new fields are present
in the testdef. The rest looks fine.

Cheers,
mwh

I think this looks pretty good. I have a concern we'll need some sort of evolution logic as the schema changes. However, maybe we assume this comprises the 1.0 version and hold off doing evultion stuff until we change the schema next time?

Hi Andy,

On Monday 28 January 2013 10:52 PM, Andy Doan wrote:
> I think this looks pretty good. I have a concern we'll need some sort of evolution logic as the schema changes. However, maybe we assume this comprises the 1.0 version and hold off doing evultion stuff until we change the schema next time?

I thought I can take evolution stuff in next months BP. As of now we
will have the format till date as version 1.0 and lets evolve.

Thank You.
--
Senthil Kumaran S
http://www.stylesen.org/
http://www.sasenthilkumaran.com/

Senthil Kumaran S <email address hidden> writes:

> === modified file 'lava_dispatcher/test_data.py'
> --- lava_dispatcher/test_data.py 2012-07-31 20:20:02 +0000
> +++ lava_dispatcher/test_data.py 2013-01-28 08:54:19 +0000
> @@ -34,7 +34,8 @@
> def __init__(self, test_id='lava'):
> self.job_status = 'pass'
> self.metadata = {}
> - self._test_run = { 'test_results':[], 'attachments':[], 'tags':[] }
> + self._test_run = { 'test_results':[], 'attachments':[], 'tags':[],
> + 'testdef_metadata':{} }

Does this actually work? The 1.5 bundle format:

http://bazaar.launchpad.net/~linaro-validation/linaro-python-dashboard-bundle/trunk/view/head:/linaro_dashboard_bundle/schemas/dashboard_bundle_format_1.5.json

doesn't allow a testdef_metadata property on elements of the test_run
array.

> self._test_run['test_id'] = test_id
> self._assign_date()
> self._assign_uuid()
> @@ -75,4 +76,3 @@
> def get_test_run(self):
> self.add_result('job_complete', self.job_status)
> return self._test_run
> -
>

Senthil Kumaran S <email address hidden> writes:

> Hi Andy,
>
> On Monday 28 January 2013 10:52 PM, Andy Doan wrote:
>> I think this looks pretty good. I have a concern we'll need some sort of evolution logic as the schema changes. However, maybe we assume this comprises the 1.0 version and hold off doing evultion stuff until we change the schema next time?
>
> I thought I can take evolution stuff in next months BP. As of now we
> will have the format till date as version 1.0 and lets evolve.

This makes sense to me.

On Tuesday 29 January 2013 06:46 AM, Michael Hudson-Doyle wrote:
> http://bazaar.launchpad.net/~linaro-validation/linaro-python-dashboard-bundle/trunk/view/head:/linaro_dashboard_bundle/schemas/dashboard_bundle_format_1.5.json
>
> doesn't allow a testdef_metadata property on elements of the test_run
> array.

I did patched linaro-python-dashboard-bundle along with this BP -
https://blueprints.launchpad.net/lava-dispatcher/+spec/add-on-to-testdef-yaml-format

The branch is here -
https://code.launchpad.net/~stylesen/linaro-python-dashboard-bundle/add-on-to-testdef-yaml

Thank You.
--
Senthil Kumaran S
http://www.stylesen.org/
http://www.sasenthilkumaran.com/