Merge lp://staging/~stub/launchpad/bug-778338-transient-schema into lp://staging/launchpad

Proposed by Stuart Bishop
Status: Work in progress
Proposed branch: lp://staging/~stub/launchpad/bug-778338-transient-schema
Merge into: lp://staging/launchpad
Prerequisite: lp://staging/~stub/launchpad/bug-179821-lowercase-tablenames
Diff against target: 361 lines (+78/-46)
3 files modified
lib/canonical/database/ftests/test_multitablecopy.txt (+26/-14)
lib/canonical/database/multitablecopy.py (+25/-18)
lib/canonical/database/postgresql.py (+27/-14)
To merge this branch: bzr merge lp://staging/~stub/launchpad/bug-778338-transient-schema
Reviewer Review Type Date Requested Status
Launchpad code reviewers Pending
Review via email: mp+60652@code.staging.launchpad.net

Description of the change

= Summary =

Multitable Copy creates transient tables. These may be discovered by the replication tools and make them explode because they don't know what to do with them.

== Proposed fix ==

Put the transient tables in their own schema, which will automatically be ignored. This seems cleaner than just white listing 'temp_%' and relying on a well known prefix.

== Pre-implementation notes ==

== Implementation details ==

== Tests ==

== Demo and Q/A ==

= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/canonical/database/postgresql.py
  lib/canonical/database/ftests/test_multitablecopy.txt
  lib/canonical/database/multitablecopy.py

./lib/canonical/database/ftests/test_multitablecopy.txt
       1: narrative uses a moin header.
      14: narrative uses a moin header.
      54: narrative uses a moin header.
      84: narrative uses a moin header.
     121: narrative uses a moin header.
     157: narrative uses a moin header.
     199: narrative exceeds 78 characters.
     244: narrative uses a moin header.
     274: narrative uses a moin header.
     276: narrative exceeds 78 characters.
     311: narrative exceeds 78 characters.
     439: narrative uses a moin header.
     486: narrative uses a moin header.
     498: narrative has trailing whitespace.
     590: narrative uses a moin header.
     658: narrative uses a moin header.

To post a comment you must log in.
13016. By Stuart Bishop

Merged bug-179821-lowercase-tablenames into bug-778338-transient-schema.

Unmerged revisions

13016. By Stuart Bishop

Merged bug-179821-lowercase-tablenames into bug-778338-transient-schema.

13015. By Stuart Bishop

delint

13014. By Stuart Bishop

Merged bug-179821-lowercase-tablenames into bug-778338-transient-schema.

13013. By Stuart Bishop

multitablecopy needs to create transient tables in a different schema so they are ignored for replication

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.