Merge lp://staging/~stub/charms/trusty/cassandra/fix-diskchecks into lp://staging/charms/trusty/cassandra

Proposed by Stuart Bishop
Status: Merged
Merged at revision: 374
Proposed branch: lp://staging/~stub/charms/trusty/cassandra/fix-diskchecks
Merge into: lp://staging/charms/trusty/cassandra
Diff against target: 106 lines (+24/-18)
3 files modified
hooks/actions.py (+4/-1)
hooks/helpers.py (+8/-0)
tests/test_actions.py (+12/-17)
To merge this branch: bzr merge lp://staging/~stub/charms/trusty/cassandra/fix-diskchecks
Reviewer Review Type Date Requested Status
Cory Johns (community) Approve
Review Queue (community) automated testing Needs Fixing
Review via email: mp+283760@code.staging.launchpad.net

Description of the change

Nagios disk space monitoring would fail if the various directories being monitored where not acessible to the nagios user.

This branch fixes this by instead determining the mount points of the interesting directories and checking available space on them. This also removes redundant checks, such as the common situation of the commitlog and saved_caches directories both being on the root volume.

To post a comment you must log in.
Revision history for this message
Review Queue (review-queue) wrote :

This item has failed automated testing! Results available here http://juju-ci.vapour.ws:8080/job/charm-bundle-test-lxc/2420/

review: Needs Fixing (automated testing)
371. By Stuart Bishop

Fix unittests

372. By Stuart Bishop

Merge trunk, resolve conflicts

373. By Stuart Bishop

delint

Revision history for this message
Cory Johns (johnsca) wrote :

This is an excellent improvement, and has been merged.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: