Juju Charms Collection
postgresql package

Merge lp://staging/~stub/charms/precise/postgresql/extract-pgpass into lp://staging/charms/postgresql

Proposed by Stuart Bishop on 2013-04-03

Status:	Merged
Merged at revision:	46
Proposed branch:	lp://staging/~stub/charms/precise/postgresql/extract-pgpass
Merge into:	lp://staging/charms/postgresql
Prerequisite:	lp://staging/~stub/charms/precise/postgresql/extract-repmgr
Diff against target:	99 lines (+22/-15) 2 files modified hooks/hooks.py (+17/-15) templates/recovery.conf.tmpl (+5/-0)
To merge this branch:	bzr merge lp://staging/~stub/charms/precise/postgresql/extract-pgpass
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Marco Ceppi (community)		2013-04-03	Approve on 2013-04-16
Review via email: mp+156838@code.staging.launchpad.net

Description of the change

There is no longer any need to use the global ~postgres/.pgpass file, so move it to the charm directory and move us a step closer to allowing colocation.

lp://staging/~stub/charms/precise/postgresql/extract-pgpass updated on 2013-04-16

106. By Stuart Bishop on 2013-04-10: Merged extract-repmgr into extract-pgpass.
107. By Stuart Bishop on 2013-04-10: Merged extract-repmgr into extract-pgpass.
108. By Stuart Bishop on 2013-04-16: Merged extract-repmgr into extract-pgpass.

Revision history for this message

Marco Ceppi (marcoceppi) wrote on 2013-04-16:

This looks good. However, it appears this change will break upgrades since the file location changes but current existing files aren't migrated to the new location/format. Can you confirm that this is the intended behavior?

review: Needs Information

Revision history for this message

Stuart Bishop (stub) wrote on 2013-04-16:

The upgrade-charm hook greates the new replication user (juju_replication) on the master, and publishes the password on the relationship. This triggers the config-changed hook on the hot standbys, which calls generate_pgpass() to regenerate the $PGPASSFILE.

The old file is left in ~postgres/.pgpass - I didn't want to risk removing it as I don't think I can tell if the file was generated by an old charm or added by an administrator or cohosted charm. I don't think it matters as no access is granted to the user in the pg_hba.conf access control file.

So I think we are good...

Revision history for this message

Marco Ceppi (marcoceppi) wrote on 2013-04-16:

Thanks for the clarification, LGTM

review: Approve

lp://staging/~stub/charms/precise/postgresql/extract-pgpass updated on 2013-04-17