Unity

Merge lp://staging/~stolowski/unity/no-click-preview-for-apps into lp://staging/unity

no-click-preview-for-apps
Merge into trunk

Proposed by Paweł Stołowski on 2013-07-03

Status:

Merged

Approved by:

Christopher Townsend on 2013-07-08

Approved revision:

no longer in the source branch.

Merged at revision:

3412

Proposed branch:

lp://staging/~stolowski/unity/no-click-preview-for-apps

Merge into:

lp://staging/unity

Diff against target:

135 lines (+68/-3)

4 files modified

dash/ResultView.h (+1/-0)
dash/ResultViewGrid.cpp (+1/-1)
dash/ScopeView.cpp (+10/-1)
tests/autopilot/unity/tests/test_dash.py (+56/-1)

To merge this branch:

bzr merge lp://staging/~stolowski/unity/no-click-preview-for-apps

High

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
PS Jenkins bot (community)	continuous-integration		Approve on 2013-07-08
Brandon Schaefer (community)		2013-07-03	Approve on 2013-07-05
Unity Team		2013-07-03	Pending
Review via email: mp+172787@code.staging.launchpad.net

Commit message

Activate (installed) applications on single left-click in Home and Applications scopes view.

Description of the change

Activate (installed) applications on single left-click in Home and Applications scopes view. Applications which are not installed will still be previewed first (this is handled on Application scope side which has the final say about how to handle activation request).

Note: we had a discussion in scopes team whether to expose an API to make it full controllable by scope developers, and decided not to do so, as Apps are the only exception for the default behavior and we want more control over this behavior.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2013-07-03:

PASSED: Continuous integration, rev:3399
http://jenkins.qa.ubuntu.com/job/unity-ci/181/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-saucy-amd64-ci/69
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-saucy-armhf-ci/69
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-saucy-i386-ci/69

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-ci/181/rebuild

review: Approve (continuous-integration)

Revision history for this message

Brandon Schaefer (brandontschaefer) wrote on 2013-07-03:

111 + scope = self.unity.dash.view.get_scope view_by_name("home.scope")

This is causing some error for me while trying to run the test_dash.py AP tests.

Failed to import test module: unity.tests.test_dash
Traceback (most recent call last):
  File "/usr/lib/python2.7/unittest/loader.py", line 252, in _find_tests
    module = self._get_module_from_name(name)
  File "/usr/lib/python2.7/unittest/loader.py", line 230, in _get_module_from_name
    __import__(name)
  File "/home/bschaefer/src/tmp-unity/tests/autopilot/unity/tests/test_dash.py", line 837
    scope = self.unity.dash.view.get_scope view_by_name("home.scope")
                                                       ^
SyntaxError: invalid syntax