unity-scopes-api

Merge lp://staging/~stolowski/unity-scopes-api/fix-1393382 into lp://staging/unity-scopes-api/devel

  1. fix-1393382
  2. Merge into devel
Proposed by Paweł Stołowski
Status: Merged
Approved by: Michi Henning
Approved revision: 533
Merged at revision: 534
Proposed branch: lp://staging/~stolowski/unity-scopes-api/fix-1393382
Merge into: lp://staging/unity-scopes-api/devel
Diff against target: 38 lines (+17/-9)
1 file modified
scoperegistry/FindFiles.cpp (+17/-9)
To merge this branch: bzr merge lp://staging/~stolowski/unity-scopes-api/fix-1393382
Reviewer Review Type Date Requested Status
Michi Henning (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+242063@code.staging.launchpad.net

Commit message

Catch file exception while iterating over individual scope dirs, so that a single failure doesn't break all other scopes.

Description of the change

Catch file exception while iterating over individual scope dirs, so that a single failure doesn't break all other scopes.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:532
http://jenkins.qa.ubuntu.com/job/unity-scopes-api-devel-ci/1315/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scopes-api-devel-vivid-amd64-ci/25
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scopes-api-devel-vivid-armhf-ci/25
        deb: http://jenkins.qa.ubuntu.com/job/unity-scopes-api-devel-vivid-armhf-ci/25/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scopes-api-devel-vivid-i386-ci/25

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-scopes-api-devel-ci/1315/rebuild

review: Approve (continuous-integration)
Revision history for this message
Michi Henning (michihenning) wrote :

Same comment as for the RTM version: extraneous newline. Otherwise fine!

review: Needs Fixing
lp://staging/~stolowski/unity-scopes-api/fix-1393382 updated
533. By Paweł Stołowski

No need for newline.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:533
http://jenkins.qa.ubuntu.com/job/unity-scopes-api-devel-ci/1319/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scopes-api-devel-vivid-amd64-ci/29
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scopes-api-devel-vivid-armhf-ci/29
        deb: http://jenkins.qa.ubuntu.com/job/unity-scopes-api-devel-vivid-armhf-ci/29/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scopes-api-devel-vivid-i386-ci/29

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-scopes-api-devel-ci/1319/rebuild

review: Approve (continuous-integration)
Revision history for this message
Michi Henning (michihenning) wrote :

Thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: